Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: src/hydrogen.cc

Issue 23606032: Chromium 284577 needs a mitigation CL added. There is a TODO to remove (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Additional check Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1805 matching lines...) Expand 10 before | Expand all | Expand 10 after
1816 } 1816 }
1817 } 1817 }
1818 1818
1819 if_nil.CaptureContinuation(continuation); 1819 if_nil.CaptureContinuation(continuation);
1820 } 1820 }
1821 1821
1822 1822
1823 HValue* HGraphBuilder::BuildCreateAllocationMemento(HValue* previous_object, 1823 HValue* HGraphBuilder::BuildCreateAllocationMemento(HValue* previous_object,
1824 int previous_object_size, 1824 int previous_object_size,
1825 HValue* alloc_site) { 1825 HValue* alloc_site) {
1826 // TODO(mvstanton): ASSERT altered to CHECK to diagnose chromium bug 284577 1826 ASSERT(alloc_site != NULL);
1827 CHECK(alloc_site != NULL);
1828 HInnerAllocatedObject* alloc_memento = Add<HInnerAllocatedObject>( 1827 HInnerAllocatedObject* alloc_memento = Add<HInnerAllocatedObject>(
1829 previous_object, previous_object_size); 1828 previous_object, previous_object_size);
1830 Handle<Map> alloc_memento_map( 1829 Handle<Map> alloc_memento_map(
1831 isolate()->heap()->allocation_memento_map()); 1830 isolate()->heap()->allocation_memento_map());
1832 AddStoreMapConstant(alloc_memento, alloc_memento_map); 1831 AddStoreMapConstant(alloc_memento, alloc_memento_map);
1833
1834 {
1835 // TODO(mvstanton): the code below is turned on to diagnose chromium bug
1836 // 284577.
1837 Handle<Map> alloc_site_map(isolate()->heap()->allocation_site_map());
1838 IfBuilder builder(this);
1839 builder.If<HCompareMap>(alloc_site, alloc_site_map);
1840 builder.Then();
1841 builder.Else();
1842 Add<HDebugBreak>();
1843 builder.End();
1844 }
1845
1846 HObjectAccess access = HObjectAccess::ForAllocationMementoSite(); 1832 HObjectAccess access = HObjectAccess::ForAllocationMementoSite();
1847 Add<HStoreNamedField>(alloc_memento, access, alloc_site); 1833 Add<HStoreNamedField>(alloc_memento, access, alloc_site);
1848 return alloc_memento; 1834 return alloc_memento;
1849 } 1835 }
1850 1836
1851 1837
1852 HInstruction* HGraphBuilder::BuildGetNativeContext() { 1838 HInstruction* HGraphBuilder::BuildGetNativeContext() {
1853 // Get the global context, then the native context 1839 // Get the global context, then the native context
1854 HInstruction* global_object = Add<HGlobalObject>(); 1840 HInstruction* global_object = Add<HGlobalObject>();
1855 HObjectAccess access = HObjectAccess::ForJSObjectOffset( 1841 HObjectAccess access = HObjectAccess::ForJSObjectOffset(
(...skipping 7855 matching lines...) Expand 10 before | Expand all | Expand 10 after
9711 if (ShouldProduceTraceOutput()) { 9697 if (ShouldProduceTraceOutput()) {
9712 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9698 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9713 } 9699 }
9714 9700
9715 #ifdef DEBUG 9701 #ifdef DEBUG
9716 graph_->Verify(false); // No full verify. 9702 graph_->Verify(false); // No full verify.
9717 #endif 9703 #endif
9718 } 9704 }
9719 9705
9720 } } // namespace v8::internal 9706 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698