src/objects-debug.cc - Issue 23606032: Chromium 284577 needs a mitigation CL added. There is a TODO to remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 23606032: Chromium 284577 needs a mitigation CL added. There is a TODO to remove (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Additional check Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index acb00da40ed55d5d550758037dba05f1346b6863..ad13d7f5a56a54c9a315a23ee52310835caa7e9d 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -692,11 +692,6 @@ void JSArray::JSArrayVerify() {

CHECK(elements()->IsUndefined() ||

elements()->IsFixedArray() ||

elements()->IsFixedDoubleArray());

- // TODO(mvstanton): to diagnose chromium bug 284577, remove after.

- AllocationMemento* memento = AllocationMemento::FindForJSObject(this);

- if (memento != NULL && memento->IsValid()) {

- memento->AllocationMementoVerify();

- }

}

« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »