Issue 23606010: Fix various parser bugs related to modifiers of top-level and class members.

Issue 23606010: Fix various parser bugs related to modifiers of top-level and class members. (Closed)

Created:
7 years, 3 months ago by ahe

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix various parser bugs related to modifiers of top-level and class members. BUG=http://dartbug.com/5852 BUG=http://dartbug.com/12805 BUG=http://dartbug.com/12887 BUG=http://dartbug.com/12898 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=27016

Patch Set 1 #

Total comments: 4

Patch Set 2 : Merged with r27015. #

Patch Set 3 : Address comments. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+291 lines, -145 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/patch_parser.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View		2 chunks	+22 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart	View	1 2	15 chunks	+186 lines, -54 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/scanner/partial_parser.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 2	7 chunks	+57 lines, -2 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/co19/co19-dart2dart.status	View		4 chunks	+0 lines, -12 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	1	6 chunks	+1 line, -13 lines	0 comments	Download
M	dart/tests/compiler/dart2js/message_kind_helper.dart	View		3 chunks	+6 lines, -9 lines	0 comments	Download
M	dart/tests/compiler/dart2js/message_kind_test.dart	View		2 chunks	+5 lines, -12 lines	0 comments	Download
M	dart/tests/compiler/dart2js/patch_test.dart	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View	1	7 chunks	+0 lines, -38 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/23606010/diff/1/dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart File dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart (right): https://codereview.chromium.org/23606010/diff/1/dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart#newcode681 dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart:681: return modifier; Add a comment that the caller ...

7 years, 3 months ago (2013-09-02 11:02:08 UTC) #2

ahe

Thank you, Johnni! https://codereview.chromium.org/23606010/diff/1/dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart File dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart (right): https://codereview.chromium.org/23606010/diff/1/dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart#newcode681 dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart:681: return modifier; On 2013/09/02 11:02:08, Johnni ...

7 years, 3 months ago (2013-09-02 17:49:59 UTC) #3

ahe

7 years, 3 months ago (2013-09-02 17:51:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r27016 (presubmit successful).

Expand Messages | Collapse Messages