Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: dart/tests/compiler/dart2js/message_kind_test.dart

Issue 23606010: Fix various parser bugs related to modifiers of top-level and class members. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/compiler/dart2js/message_kind_helper.dart ('k') | dart/tests/compiler/dart2js/patch_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/compiler/dart2js/message_kind_test.dart
diff --git a/dart/tests/compiler/dart2js/message_kind_test.dart b/dart/tests/compiler/dart2js/message_kind_test.dart
index 6a2e64119732061dd7f5802e00f844c31d16e551..55f9beda001e3654586d26090ba90c8dff090faf 100644
--- a/dart/tests/compiler/dart2js/message_kind_test.dart
+++ b/dart/tests/compiler/dart2js/message_kind_test.dart
@@ -27,15 +27,9 @@ main() {
}
});
List<String> names = kinds.keys.toList()..sort();
- Map<String, bool> examples = <String, bool>{};
+ List<String> examples = <String>[];
for (String name in names) {
MessageKind kind = kinds[name];
- bool expectNoHowToFix = false;
- if (name == 'READ_SCRIPT_ERROR') {
- // For this we can give no how-to-fix since the underlying error is
- // unknown.
- expectNoHowToFix = true;
- }
if (name == 'GENERIC' // Shouldn't be used.
// We can't provoke a crash.
|| name == 'COMPILER_CRASHED'
@@ -43,17 +37,16 @@ main() {
// We cannot provide examples for patch errors.
|| name.startsWith('PATCH_')) continue;
if (kind.examples != null) {
- examples[name] = expectNoHowToFix;
+ examples.add(name);
} else {
print("No example in '$name'");
}
};
var cachedCompiler;
- examples.forEach((String name, bool expectNoHowToFix) {
+ for (String name in examples) {
Stopwatch sw = new Stopwatch()..start();
- cachedCompiler = check(kinds[name], cachedCompiler,
- expectNoHowToFix: expectNoHowToFix);
+ cachedCompiler = check(kinds[name], cachedCompiler);
sw.stop();
print("Checked '$name' in ${sw.elapsedMilliseconds}ms.");
- });
+ }
}
« no previous file with comments | « dart/tests/compiler/dart2js/message_kind_helper.dart ('k') | dart/tests/compiler/dart2js/patch_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698