chrome/browser/extensions/api/management/chrome_management_api_delegate.cc - Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)

Patch Set: lazyboy's Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/chrome_management_api_delegate.h ('k') | chrome/browser/extensions/api/preference/preference_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

diff --git a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

index 93cc4a0dacd30282fe6fc182d585ad92d98c4c90..6e0998c35d2cecb0b4c0c39837b9c029abaace17 100644

--- a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

+++ b/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

@@ -242,13 +242,13 @@ ChromeManagementAPIDelegate::UninstallFunctionDelegate(

bool ChromeManagementAPIDelegate::CreateAppShortcutFunctionDelegate(

extensions::ManagementCreateAppShortcutFunction* function,

- const extensions::Extension* extension) const {

+ const extensions::Extension* extension,

+ std::string* error) const {

Browser* browser = chrome::FindBrowserWithProfile(

Profile::FromBrowserContext(function->browser_context()));

if (!browser) {

// Shouldn't happen if we have user gesture.

- function->SetError(

- extension_management_api_constants::kNoBrowserToCreateShortcut);

+ *error = extension_management_api_constants::kNoBrowserToCreateShortcut;

return false;

}