Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4285)

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 2360073002: [Extensions] Isolate ExtensionFunction results_ and error_ (Closed)
Patch Set: lazyboy's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/preference_api.cc
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc
index 554bcf2998ff34dc44d34558a25fcd7789dc2d87..89d11d66c0d6e76f922814bcf159c8a14e050dff 100644
--- a/chrome/browser/extensions/api/preference/preference_api.cc
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
@@ -737,7 +737,7 @@ bool SetPreferenceFunction::RunSync() {
transformer->ExtensionToBrowserPref(value, &error, &bad_message));
if (!browser_pref_value) {
error_ = error;
- bad_message_ = bad_message;
+ set_bad_message(bad_message);
return false;
}
EXTENSION_FUNCTION_VALIDATE(browser_pref_value->GetType() == pref->GetType());
@@ -749,7 +749,7 @@ bool SetPreferenceFunction::RunSync() {
if (!extensionPrefValue) {
error_ = ErrorUtils::FormatErrorMessage(kConversionErrorMessage,
pref->name());
- bad_message_ = true;
+ set_bad_message(true);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698