[Extensions] Isolate ExtensionFunction results_ and error_

chrome/browser/extensions/api/management/chrome_management_api_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/chrome_management_api_delegate.h"
 
 #include "base/callback_helpers.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 224 matching lines @@
     extensions::ManagementUninstallFunctionBase* function,
     const extensions::Extension* target_extension,
     bool show_programmatic_uninstall_ui) const {
   return std::unique_ptr<extensions::UninstallDialogDelegate>(
       new ManagementUninstallFunctionUninstallDialogDelegate(
           function, target_extension, show_programmatic_uninstall_ui));
 }
 
 bool ChromeManagementAPIDelegate::CreateAppShortcutFunctionDelegate(
     extensions::ManagementCreateAppShortcutFunction* function,
-    const extensions::Extension* extension) const {
+    const extensions::Extension* extension,
+    std::string* error) const {
   Browser* browser = chrome::FindBrowserWithProfile(
       Profile::FromBrowserContext(function->browser_context()));
   if (!browser) {
     // Shouldn't happen if we have user gesture.
-    function->SetError(
-        extension_management_api_constants::kNoBrowserToCreateShortcut);
+    *error = extension_management_api_constants::kNoBrowserToCreateShortcut;
     return false;
   }
 
   chrome::ShowCreateChromeAppShortcutsDialog(
       browser->window()->GetNativeWindow(), browser->profile(), extension,
       base::Bind(&extensions::ManagementCreateAppShortcutFunction::
                      OnCloseShortcutPrompt,
                  function));
 
   return true;
@@ skipping 74 matching lines @@
 
 GURL ChromeManagementAPIDelegate::GetIconURL(
     const extensions::Extension* extension,
     int icon_size,
     ExtensionIconSet::MatchType match,
     bool grayscale,
     bool* exists) const {
   return extensions::ExtensionIconSource::GetIconURL(extension, icon_size,
                                                      match, grayscale, exists);
 }