cc: Compute SurfacePropertyChanged without depending on owning layer

cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/816002e4c87216af3f9b2998896493937f47247e
Cr-Commit-Position: refs/heads/master@{#420784}

[ajuma, 2016-09-21 19:06:36]

Description was changed from

==========
WIP

BUG=
==========

to

==========
WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ajuma, 2016-09-22 21:44:28]

Description was changed from

==========
WIP

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ajuma, 2016-09-22 21:45:13]

Description was changed from

==========
cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ajuma, 2016-09-22 21:47:04]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 21:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 22:53:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 22:53:33]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-09-23 14:10:01]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[ajuma, 2016-09-23 14:10:27]

Patchset #1 (id:1) has been deleted

[ajuma, 2016-09-23 14:10:59]

https://codereview.chromium.org/2360003002/diff/20001/cc/trees/damage_tracker...
File cc/trees/damage_tracker_unittest.cc (right):

https://codereview.chromium.org/2360003002/diff/20001/cc/trees/damage_tracker...
cc/trees/damage_tracker_unittest.cc:420: translation,
child->transform_tree_index(), root->layer_tree_impl());
The layer's original position is (100, 100). Moving it to (200, 230) by
animating its transform rather than by resetting its position means we don't
need to rebuild property trees. The changes to the two tests below are similar.

[jaydasika, 2016-09-23 18:18:19]

https://codereview.chromium.org/2360003002/diff/20001/cc/trees/property_tree_...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/2360003002/diff/20001/cc/trees/property_tree_...
cc/trees/property_tree_builder.cc:1036: node.effect_changed =
PropertyChanged(layer);
I think this change has the side effect that we now damage the entire subtree
even for layer->property_changed() && !subtree_property_changed(). So, we don't
need Layer::layer_property_changed_ anymore.

[ajuma, 2016-09-23 20:56:20]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:56:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-09-23 22:31:12]

https://codereview.chromium.org/2360003002/diff/20001/cc/trees/property_tree_...
File cc/trees/property_tree_builder.cc (right):

https://codereview.chromium.org/2360003002/diff/20001/cc/trees/property_tree_...
cc/trees/property_tree_builder.cc:1036: node.effect_changed =
PropertyChanged(layer);
On 2016/09/23 18:18:19, jaydasika wrote:
> I think this change has the side effect that we now damage the entire subtree
> even for layer->property_changed() && !subtree_property_changed(). So, we
don't
> need Layer::layer_property_changed_ anymore.

Done.

[jaydasika, 2016-09-23 22:35:54]

lgtm

[commit-bot: I haz the power, 2016-09-23 22:39:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:39:40]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ajuma, 2016-09-23 22:45:15]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:45:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 23:31:02]

Description was changed from

==========
cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-23 23:31:03]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-23 23:32:58]

Description was changed from

==========
cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Compute SurfacePropertyChanged without depending on owning layer

This makes the computation of RenderSurfaceImpl::SurfacePropertyChanged
depend on property trees rather than on the surface's owning layer.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/816002e4c87216af3f9b2998896493937f47247e
Cr-Commit-Position: refs/heads/master@{#420784}
==========

[commit-bot: I haz the power, 2016-09-23 23:32:59]

Patchset 2 (id:??) landed as
https://crrev.com/816002e4c87216af3f9b2998896493937f47247e
Cr-Commit-Position: refs/heads/master@{#420784}