Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: cc/trees/property_tree_builder.cc

Issue 2360003002: cc: Compute SurfacePropertyChanged without depending on owning layer (Closed)
Patch Set: Address review comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree_builder.cc
diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc
index 4a85210b446311b33752dd2c2b6707dcd179af5f..ca124dda58e9adbc4aa5dd32e712b86d3e18684c 100644
--- a/cc/trees/property_tree_builder.cc
+++ b/cc/trees/property_tree_builder.cc
@@ -849,6 +849,14 @@ static inline bool HasCopyRequest(LayerImpl* layer) {
return !layer->test_properties()->copy_requests.empty();
}
+static inline bool PropertyChanged(Layer* layer) {
+ return layer->subtree_property_changed();
+}
+
+static inline bool PropertyChanged(LayerImpl* layer) {
+ return false;
+}
+
template <typename LayerType>
bool ShouldCreateRenderSurface(LayerType* layer,
gfx::Transform current_transform,
@@ -1025,6 +1033,7 @@ bool AddEffectNodeIfNeeded(
node.subtree_hidden = HideLayerAndSubtree(layer);
node.is_currently_animating_opacity = OpacityIsAnimating(layer);
node.is_currently_animating_filter = FilterIsAnimating(layer);
+ node.effect_changed = PropertyChanged(layer);
EffectTree& effect_tree = data_for_children->property_trees->effect_tree;
if (MaskLayer(layer)) {
« no previous file with comments | « cc/trees/layer_tree_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698