cc: Compute SurfacePropertyChanged without depending on owning layer

cc/trees/property_tree_builder.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/property_tree_builder.h"
 
 #include <stddef.h>
 
 #include <map>
 #include <set>
@@ skipping 831 matching lines @@
 }
 
 static inline bool HasCopyRequest(Layer* layer) {
   return layer->HasCopyRequest();
 }
 
 static inline bool HasCopyRequest(LayerImpl* layer) {
   return !layer->test_properties()->copy_requests.empty();
 }
 
+static inline bool PropertyChanged(Layer* layer) {
+  return layer->layer_property_changed() || layer->subtree_property_changed();
+}
+
+static inline bool PropertyChanged(LayerImpl* layer) {
+  return false;
+}
+
 template <typename LayerType>
 bool ShouldCreateRenderSurface(LayerType* layer,
                                gfx::Transform current_transform,
                                bool axis_aligned) {
   const bool preserves_2d_axis_alignment =
       (current_transform * Transform(layer)).Preserves2dAxisAlignment() &&
       axis_aligned && AnimationsPreserveAxisAlignment(layer);
   const bool is_root = !Parent(layer);
   if (is_root)
     return true;
@@ skipping 156 matching lines @@
   node.has_copy_request = HasCopyRequest(layer);
   node.filters = Filters(layer);
   node.background_filters = BackgroundFilters(layer);
   node.filters_origin = FiltersOrigin(layer);
   node.has_potential_opacity_animation = has_potential_opacity_animation;
   node.has_potential_filter_animation = has_potential_filter_animation;
   node.double_sided = DoubleSided(layer);
   node.subtree_hidden = HideLayerAndSubtree(layer);
   node.is_currently_animating_opacity = OpacityIsAnimating(layer);
   node.is_currently_animating_filter = FilterIsAnimating(layer);
+  node.effect_changed = PropertyChanged(layer);

[jaydasika, 2016/09/23 18:18:19]

I think this change has the side effect that we now damage the entire subtree
even for layer->property_changed() && !subtree_property_changed(). So, we don't
need Layer::layer_property_changed_ anymore.

[ajuma, 2016/09/23 22:31:12]

Done.

 
   EffectTree& effect_tree = data_for_children->property_trees->effect_tree;
   if (MaskLayer(layer)) {
     node.mask_layer_id = MaskLayer(layer)->id();
     effect_tree.AddMaskOrReplicaLayerId(node.mask_layer_id);
   }
   if (ReplicaLayer(layer)) {
     node.replica_layer_id = ReplicaLayer(layer)->id();
     effect_tree.AddMaskOrReplicaLayerId(node.replica_layer_id);
     if (MaskLayer(ReplicaLayer(layer))) {
@@ skipping 463 matching lines @@
     color = SkColorSetA(color, 255);
   BuildPropertyTreesTopLevelInternal(
       root_layer, page_scale_layer, inner_viewport_scroll_layer,
       outer_viewport_scroll_layer, overscroll_elasticity_layer,
       elastic_overscroll, page_scale_factor, device_scale_factor, viewport,
       device_transform, property_trees, color);
   property_trees->ResetCachedData();
 }
 
 }  // namespace cc