Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2359993002: Medium sized improvements to bot-list and task-list (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Base URL:
git@github.com:luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Medium sized improvements to bot-list and task-list Adds a bunch of columns to bot-list (battery* and *temperature) Makes lists a bit more responsive by lowering the default query amount Shorten the query params to be single letters (e.g. filters -> f) Some Polymer elements were updated because I purged and regenerated bower_components (e.g. Polymer 1.6.0 -> 1.6.1) BUG=631047 Committed: https://github.com/luci/luci-py/commit/6fa3df9d25c864979160c3bed632fdc8f8d49621

Patch Set 1 #

Patch Set 2 : Decrease bot-list default limit too #

Patch Set 3 : fix dangling div #

Total comments: 2

Patch Set 4 : condense loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -64 lines) Patch
M appengine/swarming/elements/build/elements.html View 1 2 3 8 chunks +130 lines, -11 lines 0 comments Download
M appengine/swarming/elements/build/js/js.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-filters.html View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list.html View 2 3 8 chunks +124 lines, -5 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list-data.html View 1 2 3 2 chunks +50 lines, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list-shared-behavior.html View 2 3 3 chunks +2 lines, -21 lines 0 comments Download
M appengine/swarming/elements/res/imp/botlist/bot-list-summary.html View 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/swarming/elements/res/imp/botpage/bot-page.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M appengine/swarming/elements/res/imp/common/common-behavior.html View 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/elements/res/imp/common/query-column-filter-behavior.html View 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-filters.html View 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M appengine/swarming/elements/res/imp/tasklist/task-list.html View 2 3 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/elements/res/js/alias.js View 2 3 4 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjlubick
https://screenshot.googleplex.com/8t09sQg0GUp https://screenshot.googleplex.com/wrQ3DUi1Tud See it at https://2351-aac687d-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/botlist?c=id&c=os&c=task&c=status&c=battery_temperature&c=bot_temperature&c=device_temperature&c=android_devices&c=battery_level&c=battery_voltage&c=battery_status&c=battery_health&l=100&q=batter&s=battery_temperature%3Adesc
4 years, 3 months ago (2016-09-21 19:14:01 UTC) #3
jcgregorio
lgtm https://codereview.chromium.org/2359993002/diff/30001/appengine/swarming/elements/res/imp/botlist/bot-list-data.html File appengine/swarming/elements/res/imp/botlist/bot-list-data.html (right): https://codereview.chromium.org/2359993002/diff/30001/appengine/swarming/elements/res/imp/botlist/bot-list-data.html#newcode222 appengine/swarming/elements/res/imp/botlist/bot-list-data.html:222: d.temp = aggregateTemps(d.temp); Why not do this in ...
4 years, 3 months ago (2016-09-21 19:42:22 UTC) #4
kjlubick
https://codereview.chromium.org/2359993002/diff/30001/appengine/swarming/elements/res/imp/botlist/bot-list-data.html File appengine/swarming/elements/res/imp/botlist/bot-list-data.html (right): https://codereview.chromium.org/2359993002/diff/30001/appengine/swarming/elements/res/imp/botlist/bot-list-data.html#newcode222 appengine/swarming/elements/res/imp/botlist/bot-list-data.html:222: d.temp = aggregateTemps(d.temp); On 2016/09/21 at 19:42:22, jcgregorio wrote: ...
4 years, 3 months ago (2016-09-21 20:05:53 UTC) #5
KevinL
lgtm
4 years, 3 months ago (2016-09-21 20:05:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359993002/40001
4 years, 3 months ago (2016-09-21 20:06:07 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 20:09:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:40001) as
https://github.com/luci/luci-py/commit/6fa3df9d25c864979160c3bed632fdc8f8d49621

Powered by Google App Engine
This is Rietveld 408576698