Medium sized improvements to bot-list and task-list

appengine/swarming/elements/res/imp/botlist/bot-list-data.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   This in an HTML Import-able file that contains the definition
   of the following elements:
 
     <bot-list-data>
 
@@ skipping 48 matching lines @@
   Events:
     None.
 -->
 
 <link rel="import" href="bot-list-shared-behavior.html">
 
 <dom-module id="bot-list-data">
 
   <script>
   (function(){
+    var AVAILABLE = "available";
     var BLACKLIST_DIMENSIONS = ["quarantined", "error"];
 
+    function aggregateTemps(temps) {
+      if (!temps) {
+        return {};
+      }
+      var zones = [];
+      var avg = 0;
+      for (k in temps) {
+        zones.push(k +" : "+temps[k]);
+        avg += temps[k];
+      }
+      avg = avg / zones.length
+      if (avg) {
+        avg = avg.toFixed(1);
+      } else {
+        avg = "unknown";
+      }
+      return {
+        average: avg,
+        zones: zones.join(" | ") || "unknown",
+      }
+    }
+
     Polymer({
       is: 'bot-list-data',
 
       behaviors: [
           SwarmingBehaviors.BotListBehavior,
       ],
 
       properties: {
         // inputs
         auth_headers: {
@@ skipping 90 matching lines @@
             bot.disks = [];
             for (var i = 0; i < keys.length; i++) {
               bot.disks.push({"id":keys[i], "mb":disks[keys[i]].free_mb});
             }
             // Sort these so the biggest disk comes first.
             bot.disks.sort(function(a, b) {
               return b.mb - a.mb;
             });
           }
 
-        });
+          // Make sure every bot has a state.temp object and precompute
+          // average and list of temps by zone if applicable.
+          bot.state.temp = aggregateTemps(bot.state.temp);
+
+          var devices = [];
+          var d = (bot && bot.state && bot.state.devices) || {};
+          // state.devices is like {Serial:Object}, so we need to keep the serial
+          for (key in d) {
+            var o = d[key];
+            o.serial = key;
+            o.okay = (o.state === AVAILABLE);
+            // It is easier to assume all devices on a bot are of the same type
+            // than to pick through the (incomplete) device state and find it.
+            o.device_type = this._dimension(bot, "device_type")[0];
+            devices.push(o);
+          }
+          bot.state.devices = devices;
+          devices.forEach(function(d){
+            d.temp = aggregateTemps(d.temp);

[jcgregorio, 2016/09/21 19:42:22]

Why not do this in the above loop?

[kjlubick, 2016/09/21 20:05:53]

Done.

+          });
+
+          if (bot.last_seen_ts) {
+            bot.last_seen_ts = new Date(bot.last_seen_ts);
+          }
+          if (bot.first_seen_ts) {
+            bot.first_seen_ts = new Date(bot.first_seen_ts);
+          }
+
+        }.bind(this));
         return this._list.items;
       },
 
       _fleet: function() {
         if (!this._count) {
           return {};
         }
         return {
           all: this._count.count || -1,
           alive: (this._count.count - this._count.dead) || -1,
@@ skipping 66 matching lines @@
           return;
         }
         this._getJsonAsync("_list", "/_ah/api/swarming/v1/bots/list",
           "_busy1", this.auth_headers, this.query_params);
       },
 
     });
   })();
   </script>
 </dom-module>