Medium sized improvements to bot-list and task-list

appengine/swarming/elements/res/imp/botlist/bot-list-shared-behavior.html

 <!--
   Copyright 2016 The LUCI Authors. All rights reserved.
   Use of this source code is governed under the Apache License, Version 2.0
   that can be found in the LICENSE file.
 
   window.SwarmingBehaviors.BotListBehavior contains any shared functions and
   constants used by the bot-list and its sub-elements.
 
   To use it, include
       behaviors: [SwarmingBehaviors.BotListBehavior]
   in the creation of your Polymer element.
 -->
 <link rel="import" href="/res/imp/common/common-behavior.html">
 <script>
   (function(){
-    // Taken from http://developer.android.com/reference/android/os/BatteryManager.html
-    var BATTERY_HEALTH_UNKNOWN = 1;
-    var BATTERY_HEALTH_GOOD = 2;
-    var BATTERY_STATUS_CHARGING = 2;
-
-    var UNAUTHENTICATED = "unauthenticated";
-    var AVAILABLE = "available";
     var UNKNOWN = "unknown";
 
     // This behavior wraps up all the shared bot-list functionality by
     // extending SwarmingBehaviors.CommonBehavior
     SwarmingBehaviors.BotListBehavior = [SwarmingBehaviors.CommonBehavior, {
 
       properties: {
         BOT_PROPERTIES: {
           type: Array,
           value: function() {
             // TODO(kjlubick): Add more of these things from state, as they
             // needed/useful/requested.
-            return ["disk_space", "task", "status"];
+            return ["disk_space", "task", "status", "version", "external_ip", "last_seen", "first_seen", "battery_level", "battery_voltage", "battery_temperature", "battery_status", "battery_health", "bot_temperature", "device_temperature"];
           }
         },
       },
 
       // _attribute looks first in dimension and then in state for the
       // specified attribute. This will always return an array. If there is
       // no matching attribute, ["unknown"] will be returned.
       _attribute: function(bot, attr, none) {
         none = none || UNKNOWN;
         return this._dimension(bot, attr) || this._state(bot, attr) || [none];
       },
 
       _devices: function(bot) {
-        var devices = [];
-        var d = (bot && bot.state && bot.state.devices) || {};
-        // state.devices is like {Serial:Object}, so we need to keep the serial
-        for (key in d) {
-          var o = d[key];
-          o.serial = key;
-          o.okay = (o.state === AVAILABLE);
-          // It is easier to assume all devices on a bot are of the same type
-          // than to pick through the (incomplete) device state and find it.
-          o.device_type = this._attribute(bot, "device_type")[0];
-          devices.push(o);
-        }
-        return devices;
+        return bot.state.devices;
       },
 
       // _deviceType returns the codename of a given Android device.
       _deviceType: function(device) {
         return device.device_type.toLowerCase();
       },
 
       // _dimension returns the given dimension of a bot. If it is defined, it
       // is an array of strings.
       _dimension: function(bot, dim) {
@@ skipping 25 matching lines @@
       _taskId: function(bot) {
         if (bot && bot.task_id) {
           return bot.task_id;
         }
         return "idle";
       },
 
     }];
   })()
 </script>