Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chrome/app/theme/chromium/BRANDING

Issue 2359953003: Fix up the Mac installer’s Info.plist, build with branding info (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/theme/chromium/BRANDING
diff --git a/chrome/app/theme/chromium/BRANDING b/chrome/app/theme/chromium/BRANDING
index 6a6bc265f7eeb7b97322845de6ac217e4140575f..996ca151a0f495d68add980702e9ef740fbfaab5 100644
--- a/chrome/app/theme/chromium/BRANDING
+++ b/chrome/app/theme/chromium/BRANDING
@@ -6,4 +6,5 @@ PRODUCT_INSTALLER_FULLNAME=Chromium Installer
PRODUCT_INSTALLER_SHORTNAME=Chromium Installer
COPYRIGHT=Copyright 2016 The Chromium Authors. All rights reserved.
MAC_BUNDLE_ID=org.chromium.Chromium
+MAC_INSTALLER_BUNDLE_ID=org.chromium.Chromium.installer
Sidney San Martín 2016/09/21 21:18:39 I could just compose the installer's bundle ID as
Robert Sesek 2016/09/21 21:41:21 I think it's fine to use the base MAC_BUNDLE_ID (i
Sidney San Martín 2016/09/21 23:19:20 Done.
MAC_CREATOR_CODE=Cr24

Powered by Google App Engine
This is Rietveld 408576698