Fix up the Mac installer’s Info.plist, build with branding info

build/util/branding.gni

Index: build/util/branding.gni
diff --git a/build/util/branding.gni b/build/util/branding.gni
index c38d2a9fc72c177b5ee8e6bf05471c0758d5a757..34a8c5ee23248f29a0932eb362c4fb7e28cc81a3 100644
--- a/build/util/branding.gni
+++ b/build/util/branding.gni
@@ -14,10 +14,14 @@
 
 import("//build/config/chrome_build.gni")
 
-_branding_dictionary_template = "full_name = \"@PRODUCT_FULLNAME@\" " +
-                                "short_name = \"@PRODUCT_SHORTNAME@\" " +
-                                "bundle_id = \"@MAC_BUNDLE_ID@\" " +
-                                "creator_code = \"@MAC_CREATOR_CODE@\" "
+_branding_dictionary_template =
+    "full_name = \"@PRODUCT_FULLNAME@\" " +

[Robert Sesek, 2016/09/21 21:41:21]

Did gn format not try and change this?

[Sidney San Martín, 2016/09/21 23:19:20]

gn format *did* this.

[Robert Sesek, 2016/09/22 14:46:55]

Oh, cool. I was trying to convince it that this was a superior formatting, but
it would not agree.

+    "short_name = \"@PRODUCT_SHORTNAME@\" " +
+    "bundle_id = \"@MAC_BUNDLE_ID@\" " +
+    "creator_code = \"@MAC_CREATOR_CODE@\" " +
+    "installer_full_name = \"@PRODUCT_INSTALLER_FULLNAME@\" " +
+    "installer_short_name = \"@PRODUCT_INSTALLER_SHORTNAME@\" " +
+    "installer_bundle_id = \"@MAC_INSTALLER_BUNDLE_ID@\" "
 
 _branding_file = "//chrome/app/theme/$branding_path_component/BRANDING"
 _result = exec_script("version.py",
@@ -32,8 +36,11 @@ _result = exec_script("version.py",
 
 chrome_product_full_name = _result.full_name
 chrome_product_short_name = _result.short_name
+chrome_product_installer_full_name = _result.installer_full_name
+chrome_product_installer_short_name = _result.installer_short_name
 
 if (is_mac) {
   chrome_mac_bundle_id = _result.bundle_id
   chrome_mac_creator_code = _result.creator_code
+  chrome_mac_installer_bundle_id = _result.installer_bundle_id
 }