chrome/app/theme/chromium/BRANDING - Issue 2359953003: Fix up the Mac installer’s Info.plist, build with branding info

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/theme/chromium/BRANDING

Issue 2359953003: Fix up the Mac installer’s Info.plist, build with branding info (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 COMPANY_FULLNAME=The Chromium Authors	1 COMPANY_FULLNAME=The Chromium Authors

2 COMPANY_SHORTNAME=The Chromium Authors	2 COMPANY_SHORTNAME=The Chromium Authors

3 PRODUCT_FULLNAME=Chromium	3 PRODUCT_FULLNAME=Chromium

4 PRODUCT_SHORTNAME=Chromium	4 PRODUCT_SHORTNAME=Chromium

5 PRODUCT_INSTALLER_FULLNAME=Chromium Installer	5 PRODUCT_INSTALLER_FULLNAME=Chromium Installer

6 PRODUCT_INSTALLER_SHORTNAME=Chromium Installer	6 PRODUCT_INSTALLER_SHORTNAME=Chromium Installer

7 COPYRIGHT=Copyright 2016 The Chromium Authors. All rights reserved.	7 COPYRIGHT=Copyright 2016 The Chromium Authors. All rights reserved.

8 MAC_BUNDLE_ID=org.chromium.Chromium	8 MAC_BUNDLE_ID=org.chromium.Chromium

	9 MAC_INSTALLER_BUNDLE_ID=org.chromium.Chromium.installer
	Sidney San Martín 2016/09/21 21:18:39 I could just compose the installer's bundle ID as I could just compose the installer's bundle ID as "$mac_bundle_id" + ".installer", but not sure if that's a good strategy. Robert Sesek 2016/09/21 21:41:21 I think it's fine to use the base MAC_BUNDLE_ID (i Show quoted text On 2016/09/21 21:18:39, Sidney San Martín wrote: > I could just compose the installer's bundle ID as "$mac_bundle_id" + > ".installer", but not sure if that's a good strategy. I think it's fine to use the base MAC_BUNDLE_ID (it's what all our Info.plists currently do). If you want to use a new BRANDING key, you'll need to do it to the internal branding repo as well and roll its deps forward. (E.g.: https://chromereviews.googleplex.com/415397013/ and https://chromereviews.googleplex.com/430687013/) Sidney San Martín 2016/09/21 23:19:20 Done. Show quoted text On 2016/09/21 21:41:21, Robert Sesek wrote: > On 2016/09/21 21:18:39, Sidney San Martín wrote: > > I could just compose the installer's bundle ID as "$mac_bundle_id" + > > ".installer", but not sure if that's a good strategy. > > I think it's fine to use the base MAC_BUNDLE_ID (it's what all our Info.plists > currently do). If you want to use a new BRANDING key, you'll need to do it to > the internal branding repo as well and roll its deps forward. > > (E.g.: https://chromereviews.googleplex.com/415397013/ and > https://chromereviews.googleplex.com/430687013/) Done.
9 MAC_CREATOR_CODE=Cr24	10 MAC_CREATOR_CODE=Cr24

OLD	NEW

« build/util/branding.gni ('K') | « build/util/branding.gni ('k') | chrome/installer/mac/app/BUILD.gn » ('j') | chrome/installer/mac/app/BUILD.gn » ('J')