GN Windows build fixes

GN Windows build fixes

This also removes some patterns from the sources assignment filter, and adds scary comments not to make it bigger. The GYP version of this is out of control so I want to set a clear policy of what is included and not.

I removed X-related stuff from the filter (there are only about 50 files around the tree) and added manual rules for the affected files.

BUG=
R=scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263394

[scottmg, 2014-04-11 21:43:26]

https://codereview.chromium.org/235983002/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/235983002/diff/1/base/BUILD.gn#newcode815
base/BUILD.gn:815: if (!use_x11) {
why is this better?

https://codereview.chromium.org/235983002/diff/1/third_party/libusb/BUILD.gn
File third_party/libusb/BUILD.gn (right):

https://codereview.chromium.org/235983002/diff/1/third_party/libusb/BUILD.gn#...
third_party/libusb/BUILD.gn:95: "src/libusb/os/poll_posix.c",
why aren't these filtered by the set_assignment_filter?

[scottmg, 2014-04-11 21:43:31]

lgtm

[brettw, 2014-04-11 23:05:00]

https://codereview.chromium.org/235983002/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/235983002/diff/1/base/BUILD.gn#newcode815
base/BUILD.gn:815: if (!use_x11) {
Before this was only done on Linux when we weren't using X11 (since otherwise on
Linux it was always removed and this code would fail since the items weren't
found). Now its removed any time we aren't using X11.

https://codereview.chromium.org/235983002/diff/1/third_party/libusb/BUILD.gn
File third_party/libusb/BUILD.gn (right):

https://codereview.chromium.org/235983002/diff/1/third_party/libusb/BUILD.gn#...
third_party/libusb/BUILD.gn:95: "src/libusb/os/poll_posix.c",
On 2014/04/11 21:43:26, scottmg wrote:
> why aren't these filtered by the set_assignment_filter?

They're .c files. The filter only has .cc in it now. I'm not excited about
making the patterns more complicated and I don't think this will come up that
often.

[brettw, 2014-04-11 23:06:22]

Committed patchset #1 manually as r263394.

[scottmg, 2014-04-11 23:12:31]

https://codereview.chromium.org/235983002/diff/1/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/235983002/diff/1/base/BUILD.gn#newcode815
base/BUILD.gn:815: if (!use_x11) {
On 2014/04/11 23:05:00, brettw wrote:
> Before this was only done on Linux when we weren't using X11 (since otherwise
on
> Linux it was always removed and this code would fail since the items weren't
> found). Now its removed any time we aren't using X11.

Oops, sorry, can't read.

https://codereview.chromium.org/235983002/diff/1/third_party/libusb/BUILD.gn
File third_party/libusb/BUILD.gn (right):

https://codereview.chromium.org/235983002/diff/1/third_party/libusb/BUILD.gn#...
third_party/libusb/BUILD.gn:95: "src/libusb/os/poll_posix.c",
On 2014/04/11 23:05:00, brettw wrote:
> On 2014/04/11 21:43:26, scottmg wrote:
> > why aren't these filtered by the set_assignment_filter?
> 
> They're .c files. The filter only has .cc in it now. I'm not excited about
> making the patterns more complicated and I don't think this will come up that
> often.

Ah, missed that. Makes sense I guess, but I feel like people will probably get
bitten now and then.