third_party/libusb/BUILD.gn - Issue 235983002: GN Windows build fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libusb/BUILD.gn

Issue 235983002: GN Windows build fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libusb/BUILD.gn

diff --git a/third_party/libusb/BUILD.gn b/third_party/libusb/BUILD.gn

index 837e53c213bb85796b39ef062f16014613f439b6..27761efa0da49b3694d425fe8ec0d6a94a3c4829 100644

--- a/third_party/libusb/BUILD.gn

+++ b/third_party/libusb/BUILD.gn

@@ -91,6 +91,10 @@ static_library("libusb") {

if (is_win) {

include_dirs += [ "src/msvc" ]

+ sources -= [

+ "src/libusb/os/poll_posix.c",

scottmg 2014/04/11 21:43:26 why aren't these filtered by the set_assignment_fi

brettw 2014/04/11 23:05:00 They're .c files. The filter only has .cc in it no

scottmg 2014/04/11 23:12:31 Ah, missed that. Makes sense I guess, but I feel l

+ "src/libusb/os/threads_posix.c",

+ ]

} else {

include_dirs += [ "src" ]

sources -= [