Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: base/BUILD.gn

Issue 235983002: GN Windows build fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | third_party/libusb/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index cc9500d818c04a06c0b248bdb414eda5f3d33d8d..1eddbf7efac14da08e9612ff283452eaf671a42f 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -788,13 +788,6 @@ component("base") {
linux_configs += [
"//build/config/linux:x11",
]
- } else {
- # On non-Linux platforms, the X11 files will already have been filtered
- # out using the sources assignment filter.
- sources -= [
- "message_loop/message_pump_x11.cc",
- "message_loop/message_pump_x11.h",
- ]
}
configs += linux_configs
@@ -819,6 +812,13 @@ component("base") {
]
}
+ if (!use_x11) {
scottmg 2014/04/11 21:43:26 why is this better?
brettw 2014/04/11 23:05:00 Before this was only done on Linux when we weren't
scottmg 2014/04/11 23:12:31 Oops, sorry, can't read.
+ sources -= [
+ "message_loop/message_pump_x11.cc",
+ "message_loop/message_pump_x11.h",
+ ]
+ }
+
if (!use_glib) {
sources -= [
"message_loop/message_pump_glib.cc",
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | third_party/libusb/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698