Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 23597045: Land Recent QUIC changes. (Closed)

Created:
7 years, 3 months ago by ramant (doing other things)
Modified:
7 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Visibility:
Public.

Description

Land Recent QUIC changes. Pass HasRetransmittableData to the congestion manager and the send algorithm. This allows tcp_cubic_sender to not count ACK-only packets against the congestion window. Merge internal change: 51829697 If a previously zombie'd QUIC stream is closed and the headers have been decompressed, remove that entry from the zombie stream map. Merge internal change: 51697989 Change the value used to set the sequence number with to both correctly calculate the widest packet spread currently outstanding and fix a DCHECK failure in EndToEnd's Uber test when packets were transmitted sufficiently out of order that the packet being sent was less than the last packet the peer was awaiting. Merge internal change: 51644967 Fix a bug where frames are queued and not enough room for the next stream frame is available, but we attempt to create a STREAM frame anyway in ConsumeData. Merge internal change: 51604946 Changed Delayed Ack Timer to go off before the sender's retransmission timer goes off. Merge internal change: 51594956 Using the priorities sent by the client, including bounds checking, and bumping the priority of initial writes to avoid the HOL header blocking issue. Merge internal change: 51586426 Fix memory leak uncovered by https://codereview.chromium.org/23587004 Merge internal change: 51569066 Added logging of QUIC version negotiated. Export number of QUIC sessions and streams for each QUIC version. Merge internal change: 51540178 A refactor of QuicFdWrapper's writev to pass the iovec all the way to QuicConnection, allowing better packet packing. Merge internal change: 51530908 Enabled priorities in chrome quic streams. R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223880

Patch Set 1 #

Patch Set 2 : compile fixes #

Patch Set 3 : fixed rch's comments #

Patch Set 4 : Merged QuicPriority to RequestPriority changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1058 lines, -334 lines) Patch
M net/base/net_log_event_type_list.h View 1 chunk +6 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +6 lines, -4 lines 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M net/quic/congestion_control/fix_rate_test.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.h View 1 chunk +6 lines, -4 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/quic_congestion_control_test.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M net/quic/congestion_control/quic_congestion_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M net/quic/congestion_control/quic_congestion_manager.cc View 2 chunks +30 lines, -10 lines 0 comments Download
M net/quic/congestion_control/quic_congestion_manager_test.cc View 8 chunks +25 lines, -14 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +6 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +6 lines, -4 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 2 chunks +18 lines, -1 line 0 comments Download
M net/quic/quic_client_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 5 chunks +16 lines, -6 lines 0 comments Download
M net/quic/quic_connection.cc View 1 12 chunks +71 lines, -50 lines 0 comments Download
M net/quic/quic_connection_helper_test.cc View 8 chunks +23 lines, -13 lines 0 comments Download
M net/quic/quic_connection_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 83 chunks +225 lines, -72 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream.h View 3 chunks +9 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 2 3 8 chunks +13 lines, -3 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 2 3 14 chunks +75 lines, -14 lines 0 comments Download
A net/quic/quic_http_utils.h View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A net/quic/quic_http_utils.cc View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A net/quic/quic_http_utils_test.cc View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 3 chunks +31 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 2 chunks +44 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.h View 3 chunks +6 lines, -2 lines 0 comments Download
M net/quic/quic_reliable_client_stream.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_session.h View 3 chunks +9 lines, -5 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +13 lines, -7 lines 0 comments Download
M net/quic/quic_session_test.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_stream_sequencer.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_utils.cc View 3 chunks +3 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream.h View 4 chunks +20 lines, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 5 chunks +37 lines, -7 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 1 2 17 chunks +28 lines, -33 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +10 lines, -6 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 6 chunks +19 lines, -11 lines 0 comments Download
M net/tools/quic/quic_reliable_server_stream_test.cc View 6 chunks +19 lines, -13 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
7 years, 3 months ago (2013-09-14 02:26:52 UTC) #1
ramant (doing other things)
PTAL (this is a merge of changes plus review comments for priority CL). thanks much.
7 years, 3 months ago (2013-09-17 20:41:48 UTC) #2
Ryan Hamilton
lgtm since i have reviews all the individual changes,
7 years, 3 months ago (2013-09-18 03:38:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23597045/72001
7 years, 3 months ago (2013-09-18 05:30:31 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, chrome_frame_net_tests, chrome_frame_tests, chrome_frame_unittests, content_browsertests, mini_installer_test, ...
7 years, 3 months ago (2013-09-18 07:41:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/23597045/72001
7 years, 3 months ago (2013-09-18 13:17:03 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 15:36:59 UTC) #7
Message was sent while issue was closed.
Change committed as 223880

Powered by Google App Engine
This is Rietveld 408576698