Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 23587004: If the stream is being closed locally (for example in the case of a (Closed)

Created:
7 years, 3 months ago by Ryan Hamilton
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

If the stream is being closed locally (for example in the case of a client, the user may cancel the request before the response is received from the server) then we need to make sure that we keep the stream alive long enough to process any response or RST_STREAM that the server sends. This should dramatically reduce (possibly eliminate) the instances of STREAM_RST_BEFORE_HEADERS_DECOMPRESSED errors from Chrome. (This is currently the second most common cause of QUIC sessions closure, behind the expected TIMED_OUT) Merge internal change: 51442891 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220153

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -29 lines) Patch
M net/quic/quic_client_session.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_client_session.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_http_stream.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 5 chunks +19 lines, -5 lines 0 comments Download
M net/quic/quic_protocol.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_session.h View 2 chunks +24 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 9 chunks +86 lines, -11 lines 0 comments Download
M net/quic/quic_session_test.cc View 10 chunks +75 lines, -10 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Hamilton
7 years, 3 months ago (2013-08-27 17:19:45 UTC) #1
ramant (doing other things)
lgtm
7 years, 3 months ago (2013-08-27 17:41:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/23587004/1
7 years, 3 months ago (2013-08-27 17:46:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/23587004/1
7 years, 3 months ago (2013-08-28 00:06:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/23587004/1
7 years, 3 months ago (2013-08-28 01:21:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=80940
7 years, 3 months ago (2013-08-28 02:11:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/23587004/28001
7 years, 3 months ago (2013-08-28 19:11:45 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 01:03:09 UTC) #8
Message was sent while issue was closed.
Change committed as 220153

Powered by Google App Engine
This is Rietveld 408576698