Land Recent QUIC changes.

net/quic/reliable_quic_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/reliable_quic_stream.h"
 
 #include "net/quic/quic_session.h"
 #include "net/quic/quic_spdy_decompressor.h"
+#include "net/spdy/write_blocked_list.h"
 
 using base::StringPiece;
 using std::min;
 
 namespace net {
 
 namespace {
 
 // This is somewhat arbitrary.  It's possible, but unlikely, we will either fail
 // to set a priority client-side, or cancel a stream before stripping the
@@ skipping 167 matching lines @@
 
 bool ReliableQuicStream::GetSSLInfo(SSLInfo* ssl_info) {
   return session_->GetSSLInfo(ssl_info);
 }
 
 QuicConsumedData ReliableQuicStream::WriteData(StringPiece data, bool fin) {
   DCHECK(data.size() > 0 || fin);
   return WriteOrBuffer(data, fin);
 }
 
+
+void ReliableQuicStream::set_priority(QuicPriority priority) {
+  DCHECK_EQ(0u, stream_bytes_written_);
+  priority_ = priority;
+}
+
 QuicConsumedData ReliableQuicStream::WriteOrBuffer(StringPiece data, bool fin) {
   DCHECK(!fin_buffered_);
 
   QuicConsumedData consumed_data(0, false);
   fin_buffered_ = fin;
 
   if (queued_data_.empty()) {
     consumed_data = WriteDataInternal(string(data.data(), data.length()), fin);
     DCHECK_LE(consumed_data.bytes_consumed, data.length());
   }
@@ skipping 22 matching lines @@
       queued_data_.pop_front();
     } else {
       queued_data_.front().erase(0, consumed_data.bytes_consumed);
       break;
     }
   }
 }
 
 QuicConsumedData ReliableQuicStream::WriteDataInternal(
     StringPiece data, bool fin) {
+  struct iovec iov = {const_cast<char*>(data.data()),
+                      static_cast<size_t>(data.size())};
+  return WritevDataInternal(&iov, 1, fin);
+}
+
+QuicConsumedData ReliableQuicStream::WritevDataInternal(const struct iovec* iov,
+                                                        int count,
+                                                        bool fin) {
   if (write_side_closed_) {
     DLOG(ERROR) << "Attempt to write when the write side is closed";
     return QuicConsumedData(0, false);
   }
 
+  size_t write_length = 0u;
+  for (int i = 0; i < count; ++i) {
+    write_length += iov[i].iov_len;
+  }
   QuicConsumedData consumed_data =
-      session()->WriteData(id(), data, stream_bytes_written_, fin);
+      session()->WritevData(id(), iov, count, stream_bytes_written_, fin);
   stream_bytes_written_ += consumed_data.bytes_consumed;
-  if (consumed_data.bytes_consumed == data.length()) {
+  if (consumed_data.bytes_consumed == write_length) {
     if (fin && consumed_data.fin_consumed) {
       fin_sent_ = true;
       CloseWriteSide();
     } else if (fin && !consumed_data.fin_consumed) {
-      session_->MarkWriteBlocked(id());
+      session_->MarkWriteBlocked(id(), EffectivePriority());
     }
   } else {
-    session_->MarkWriteBlocked(id());
+    session_->MarkWriteBlocked(id(), EffectivePriority());
   }
   return consumed_data;
 }
 
+QuicPriority ReliableQuicStream::EffectivePriority() const {
+  return priority();
+}
+
 void ReliableQuicStream::CloseReadSide() {
   if (read_side_closed_) {
     return;
   }
   DLOG(INFO) << "Done reading from stream " << id();
 
   read_side_closed_ = true;
   if (write_side_closed_) {
     DLOG(INFO) << "Closing stream: " << id();
     session_->CloseStream(id());
   }
 }
 
 uint32 ReliableQuicStream::ProcessRawData(const char* data, uint32 data_len) {
   if (id() == kCryptoStreamId) {
     if (data_len == 0) {
       return 0;
     }
     // The crypto stream does not use compression.
     return ProcessData(data, data_len);
   }
 
   uint32 total_bytes_consumed = 0;
   if (headers_id_ == 0u) {
     total_bytes_consumed += StripPriorityAndHeaderId(data, data_len);
     data += total_bytes_consumed;
     data_len -= total_bytes_consumed;
-    if (data_len == 0) {
+    if (data_len == 0 || !session_->connection()->connected()) {
       return total_bytes_consumed;
     }
   }
   DCHECK_NE(0u, headers_id_);
 
   // Once the headers are finished, we simply pass the data through.
   if (headers_decompressed_) {
     // Some buffered header data remains.
     if (!decompressed_headers_.empty()) {
       ProcessHeaderData();
@@ skipping 161 matching lines @@
   }
 }
 
 uint32 ReliableQuicStream::StripPriorityAndHeaderId(
     const char* data, uint32 data_len) {
   uint32 total_bytes_parsed = 0;
 
   if (!priority_parsed_ &&
       session_->connection()->version() >= QUIC_VERSION_9 &&
       session_->connection()->is_server()) {
+    QuicPriority temporary_priority = priority_;
     total_bytes_parsed = StripUint32(
-        data, data_len, &headers_id_and_priority_buffer_, &priority_);
+        data, data_len, &headers_id_and_priority_buffer_, &temporary_priority);
     if (total_bytes_parsed > 0 && headers_id_and_priority_buffer_.size() == 0) {
-      // TODO(alyssar) check for priority out of bounds.
       priority_parsed_ = true;
+      // Spdy priorities are inverted, so the highest numerical value is the
+      // lowest legal priority.
+      if (temporary_priority > static_cast<QuicPriority>(kLowestPriority)) {
+        session_->connection()->SendConnectionClose(QUIC_INVALID_PRIORITY);
+        return 0;
+      }
+      priority_ = temporary_priority;
     }
     data += total_bytes_parsed;
     data_len -= total_bytes_parsed;
   }
   if (data_len > 0 && headers_id_ == 0u) {
     // The headers ID has not yet been read.  Strip it from the beginning of
     // the data stream.
     total_bytes_parsed += StripUint32(
         data, data_len, &headers_id_and_priority_buffer_, &headers_id_);
   }
   return total_bytes_parsed;
 }
 
 }  // namespace net