Replaced PassRefPtr copies with moves.

Replaced PassRefPtr copies with moves.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

The PassRefPtr copies in this patch were those that were more difficult
to find (those involved in templates and cross thread) and new ones
added since previous patches.

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d
Cr-Commit-Position: refs/heads/master@{#420173}

[Bugs Nash, 2016-09-20 23:22:11]

Description was changed from

==========
Replaced PassRefPtr copies with moves.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

The PassRefPtr copies in this patch were those that were more difficult
to find (those involved in templates and cross thread) and new ones
added since previous patches.

BUG=640449
==========

to

==========
Replaced PassRefPtr copies with moves.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

The PassRefPtr copies in this patch were those that were more difficult
to find (those involved in templates and cross thread) and new ones
added since previous patches.

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Bugs Nash, 2016-09-20 23:23:18]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 23:23:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2016-09-20 23:42:30]

bugsnash@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:34:45]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-09-21 00:40:50]

LGTM

Just to confirm: If we forget to add std::move, will we get some compile error?

[Bugs Nash, 2016-09-21 00:43:00]

On 2016/09/21 at 00:40:50, haraken wrote:
> LGTM
> 
> Just to confirm: If we forget to add std::move, will we get some compile
error?

No, not until I remove the PassRefPtr copy constructor (at which point I will
fix any new copies that have been added). I can't remove the PassRefPtr copy
constructor yet as there are still some complicated copies happening in unit
tests that I need to figure out.

[haraken, 2016-09-21 00:44:41]

On 2016/09/21 00:43:00, Bugs Nash wrote:
> On 2016/09/21 at 00:40:50, haraken wrote:
> > LGTM
> > 
> > Just to confirm: If we forget to add std::move, will we get some compile
> error?
> 
> No, not until I remove the PassRefPtr copy constructor (at which point I will
> fix any new copies that have been added). I can't remove the PassRefPtr copy
> constructor yet as there are still some complicated copies happening in unit
> tests that I need to figure out.

I'm happy as long as we get to the point where we can get the compile error in
the end :)

[Yuta Kitamura, 2016-09-21 06:21:06]

On 2016/09/21 00:44:41, haraken wrote:
> On 2016/09/21 00:43:00, Bugs Nash wrote:
> > On 2016/09/21 at 00:40:50, haraken wrote:
> > > LGTM
> > > 
> > > Just to confirm: If we forget to add std::move, will we get some compile
> > error?
> > 
> > No, not until I remove the PassRefPtr copy constructor (at which point I
will
> > fix any new copies that have been added). I can't remove the PassRefPtr copy
> > constructor yet as there are still some complicated copies happening in unit
> > tests that I need to figure out.
> 
> I'm happy as long as we get to the point where we can get the compile error in
> the end :)

Well, in this case the lack of std::move() won't cause a compile
error in the end (i.e. when we completely get rid of PassRefPtr),
because RefPtr has a copy constructor. However, this is the same
as the current situation, where we selectively call or don't call
.release() on a RefPtr based on whether we can give out the
ownership or not.

[Yuta Kitamura, 2016-09-21 06:21:26]

lgtm

[Bugs Nash, 2016-09-21 21:46:23]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:46:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 21:53:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 21:55:35]

Description was changed from

==========
Replaced PassRefPtr copies with moves.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

The PassRefPtr copies in this patch were those that were more difficult
to find (those involved in templates and cross thread) and new ones
added since previous patches.

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Replaced PassRefPtr copies with moves.

Part of making PassRefPtr move only, in preparation for the removal of
PassRefPtr.

The PassRefPtr copies in this patch were those that were more difficult
to find (those involved in templates and cross thread) and new ones
added since previous patches.

BUG=640449
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d
Cr-Commit-Position: refs/heads/master@{#420173}
==========

[commit-bot: I haz the power, 2016-09-21 21:55:37]

Patchset 1 (id:??) landed as
https://crrev.com/0b54afe50728088d9434c02a9f8cca6d7180226d
Cr-Commit-Position: refs/heads/master@{#420173}