Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2359553003: Replaced PassRefPtr copies with moves. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ScriptState.h" 5 #include "bindings/core/v8/ScriptState.h"
6 6
7 #include "bindings/core/v8/V8Binding.h" 7 #include "bindings/core/v8/V8Binding.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/LocalDOMWindow.h" 9 #include "core/frame/LocalDOMWindow.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 PassRefPtr<ScriptState> ScriptState::create(v8::Local<v8::Context> context, Pass RefPtr<DOMWrapperWorld> world) 14 PassRefPtr<ScriptState> ScriptState::create(v8::Local<v8::Context> context, Pass RefPtr<DOMWrapperWorld> world)
15 { 15 {
16 RefPtr<ScriptState> scriptState = adoptRef(new ScriptState(context, world)); 16 RefPtr<ScriptState> scriptState = adoptRef(new ScriptState(context, std::mov e(world)));
17 // This ref() is for keeping this ScriptState alive as long as the v8::Conte xt is alive. 17 // This ref() is for keeping this ScriptState alive as long as the v8::Conte xt is alive.
18 // This is deref()ed in the weak callback of the v8::Context. 18 // This is deref()ed in the weak callback of the v8::Context.
19 scriptState->ref(); 19 scriptState->ref();
20 return scriptState; 20 return scriptState;
21 } 21 }
22 22
23 static void derefCallback(const v8::WeakCallbackInfo<ScriptState>& data) 23 static void derefCallback(const v8::WeakCallbackInfo<ScriptState>& data)
24 { 24 {
25 data.GetParameter()->deref(); 25 data.GetParameter()->deref();
26 } 26 }
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 v8::HandleScope handleScope(toIsolate(frame)); 102 v8::HandleScope handleScope(toIsolate(frame));
103 v8::Local<v8::Context> context = toV8Context(frame, world); 103 v8::Local<v8::Context> context = toV8Context(frame, world);
104 if (context.IsEmpty()) 104 if (context.IsEmpty())
105 return nullptr; 105 return nullptr;
106 ScriptState* scriptState = ScriptState::from(context); 106 ScriptState* scriptState = ScriptState::from(context);
107 ASSERT(scriptState->contextIsValid()); 107 ASSERT(scriptState->contextIsValid());
108 return scriptState; 108 return scriptState;
109 } 109 }
110 110
111 } // namespace blink 111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698