third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp - Issue 2359553003: Replaced PassRefPtr copies with moves.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 2359553003: Replaced PassRefPtr copies with moves. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

index 86f55cf43657623b7738f4277e8607888ead28f5..510bc5bc24f7c1023950c276647e9f239c03ad5a 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

@@ -13,7 +13,7 @@ namespace blink {

PassRefPtr<ScriptState> ScriptState::create(v8::Local<v8::Context> context, PassRefPtr<DOMWrapperWorld> world)

{

- RefPtr<ScriptState> scriptState = adoptRef(new ScriptState(context, world));

+ RefPtr<ScriptState> scriptState = adoptRef(new ScriptState(context, std::move(world)));

// This ref() is for keeping this ScriptState alive as long as the v8::Context is alive.

// This is deref()ed in the weak callback of the v8::Context.

scriptState->ref();