Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Set flags.

https://codereview.chromium.org/2359613002/

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

https://codereview.chromium.org/2352043004/

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

https://codereview.chromium.org/2351963005/

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

https://codereview.chromium.org/2351303003/

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

https://codereview.chromium.org/2353123002/

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

https://codereview.chromium.org/2356873002/

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

https://codereview.chromium.org/2353063002/

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

https://codereview.chromium.org/2350173005/

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

https://codereview.chromium.org/2353763002/

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

https://codereview.chromium.org/2355493004/

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

https://codereview.chromium.org/2349373002/

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

https://codereview.chromium.org/2351673003/

Fix bizarro comment formatting

Merge internal change: 132917785

https://codereview.chromium.org/2346323003/

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

https://codereview.chromium.org/2352803002/

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

https://codereview.chromium.org/2354563003/

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

https://codereview.chromium.org/2351813002/

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

https://codereview.chromium.org/2350863002/

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

https://codereview.chromium.org/2354673002/

BUG=

Committed: https://crrev.com/1660498884cb6b0f99f77299b304c4703a8b5023
Cr-Commit-Position: refs/heads/master@{#419942}

[Jana, 2016-09-20 21:20:08]

The CQ bit was checked by jri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 21:20:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jana, 2016-09-20 21:34:32]

Description was changed from

==========
Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Set flags.

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

Fix bizarro comment formatting

n/a comment changes only.

Merge internal change: 132917785

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

BUG=
==========

to

==========
Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Set flags.

https://codereview.chromium.org/2359613002/

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

https://codereview.chromium.org/2352043004/

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

https://codereview.chromium.org/2351963005/

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

https://codereview.chromium.org/2351303003/

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

https://codereview.chromium.org/2353123002/

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

https://codereview.chromium.org/2356873002/

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

https://codereview.chromium.org/2353063002/

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

https://codereview.chromium.org/2350173005/

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

https://codereview.chromium.org/2353763002/

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

https://codereview.chromium.org/2355493004/

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

https://codereview.chromium.org/2349373002/

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

https://codereview.chromium.org/2351673003/

Fix bizarro comment formatting

Merge internal change: 132917785

https://codereview.chromium.org/2346323003/

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

https://codereview.chromium.org/2352803002/

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

https://codereview.chromium.org/2354563003/

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

https://codereview.chromium.org/2351813002/

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

https://codereview.chromium.org/2350863002/

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

https://codereview.chromium.org/2354673002/

BUG=
==========

[Jana, 2016-09-20 21:35:45]

jri@chromium.org changed reviewers:
+ rch@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:03:29]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Jana, 2016-09-20 22:14:20]

The CQ bit was checked by jri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:15:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-09-20 22:26:19]

lgtm, modulo the question I asked on the flag CL.

[commit-bot: I haz the power, 2016-09-20 23:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:15:25]

Dry run: This issue passed the CQ dry run.

[Jana, 2016-09-20 23:24:09]

The CQ bit was checked by jri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 23:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:39:45]

Dry run: This issue passed the CQ dry run.

[Jana, 2016-09-21 01:53:29]

The CQ bit was checked by jri@chromium.org

[Jana, 2016-09-21 01:53:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2359503003/#ps40001
(title: "Reverted flag flip.")

[commit-bot: I haz the power, 2016-09-21 01:54:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 02:01:11]

Description was changed from

==========
Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Set flags.

https://codereview.chromium.org/2359613002/

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

https://codereview.chromium.org/2352043004/

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

https://codereview.chromium.org/2351963005/

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

https://codereview.chromium.org/2351303003/

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

https://codereview.chromium.org/2353123002/

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

https://codereview.chromium.org/2356873002/

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

https://codereview.chromium.org/2353063002/

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

https://codereview.chromium.org/2350173005/

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

https://codereview.chromium.org/2353763002/

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

https://codereview.chromium.org/2355493004/

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

https://codereview.chromium.org/2349373002/

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

https://codereview.chromium.org/2351673003/

Fix bizarro comment formatting

Merge internal change: 132917785

https://codereview.chromium.org/2346323003/

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

https://codereview.chromium.org/2352803002/

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

https://codereview.chromium.org/2354563003/

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

https://codereview.chromium.org/2351813002/

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

https://codereview.chromium.org/2350863002/

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

https://codereview.chromium.org/2354673002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Set flags.

https://codereview.chromium.org/2359613002/

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

https://codereview.chromium.org/2352043004/

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

https://codereview.chromium.org/2351963005/

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

https://codereview.chromium.org/2351303003/

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

https://codereview.chromium.org/2353123002/

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

https://codereview.chromium.org/2356873002/

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

https://codereview.chromium.org/2353063002/

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

https://codereview.chromium.org/2350173005/

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

https://codereview.chromium.org/2353763002/

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

https://codereview.chromium.org/2355493004/

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

https://codereview.chromium.org/2349373002/

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

https://codereview.chromium.org/2351673003/

Fix bizarro comment formatting

Merge internal change: 132917785

https://codereview.chromium.org/2346323003/

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

https://codereview.chromium.org/2352803002/

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

https://codereview.chromium.org/2354563003/

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

https://codereview.chromium.org/2351813002/

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

https://codereview.chromium.org/2350863002/

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

https://codereview.chromium.org/2354673002/

BUG=
==========

[commit-bot: I haz the power, 2016-09-21 02:01:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 02:04:40]

Description was changed from

==========
Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Set flags.

https://codereview.chromium.org/2359613002/

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

https://codereview.chromium.org/2352043004/

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

https://codereview.chromium.org/2351963005/

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

https://codereview.chromium.org/2351303003/

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

https://codereview.chromium.org/2353123002/

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

https://codereview.chromium.org/2356873002/

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

https://codereview.chromium.org/2353063002/

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

https://codereview.chromium.org/2350173005/

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

https://codereview.chromium.org/2353763002/

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

https://codereview.chromium.org/2355493004/

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

https://codereview.chromium.org/2349373002/

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

https://codereview.chromium.org/2351673003/

Fix bizarro comment formatting

Merge internal change: 132917785

https://codereview.chromium.org/2346323003/

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

https://codereview.chromium.org/2352803002/

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

https://codereview.chromium.org/2354563003/

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

https://codereview.chromium.org/2351813002/

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

https://codereview.chromium.org/2350863002/

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

https://codereview.chromium.org/2354673002/

BUG=
==========

to

==========
Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

Set flags.

https://codereview.chromium.org/2359613002/

Use Cubic when kBBR option is specified.

Merge internal change: 133469673

https://codereview.chromium.org/2352043004/

Limit QUIC's Cubic CWND increases to 1/2 the bytes acked when in
congestion avoidance. Protected by ENABLED
FLAGS_quic_limit_cubic_cwnd_increase.

Merge internal change: 133421910

https://codereview.chromium.org/2351963005/

Close connection when packet generator is trying to add a frame which
alone cannot fit into a packet. Protected by ENABLED
FLAGS_quic_close_connection_on_huge_frames.

Merge internal change: 133419402

https://codereview.chromium.org/2351303003/

Print the QuicReceivedPacketManager's ack frame instead of the
QuicPacketGenerator's ack frame to print connection debug info and
remove QuicPacketGenerator's ack frame.  Small functional change to
print useful data.

The ack frame being printed previously was never used, so would always
be in the default initialized state.

Merge internal change: 133400163

https://codereview.chromium.org/2353123002/

Extra error logging for missing SCT.  Not flag protected.

Merge internal change: 133256313

https://codereview.chromium.org/2356873002/

Only inform QUIC's SentPacketManager of packets that are actually sent,
not those that failed to be sent.  Protected by
FLAGS_quic_only_track_sent_packets.

Merge internal change: 133209233

https://codereview.chromium.org/2353063002/

QUIC enable server push by default. Guarded by
FLAGS_quic_enable_server_push_by_default.

Enable server push by default for QUIC versions 35 and higher.

Also adds support so that push can be disabled using HTTP/2
SETTINGS_ENABLE_PUSH.

Merge internal change: 133188946

https://codereview.chromium.org/2350173005/

Use refcounted ownership for ValidateClientHelloResultCallback::Result

This CL switches ValidateClientHelloResultCallback::Result to use
refcounted ownership semantics.  This has no effect in current code, but
will be useful in solving some object lifetime issues as more codepaths
are asynchronized.

Change to refcounted ownership for
ValidateClientHelloResultCallback::Result.  No functional change beyond
this intended, not flag-protected.

Merge internal change: 133129391

https://codereview.chromium.org/2353763002/

Adds CryptoHandshakeMessage::HasStringPiece method.

Merge internal change: 133121236

https://codereview.chromium.org/2355493004/

Only close the QUIC connection after 5RTOs on the client side when the
5RTO connection option is present. Protected by ENABLED
FLAGS_quic_only_5rto_client_side.

For users with relatively short RTTs, the 5th RTO on the server side can
occur before the client sends a PING.  In networks with short NAT
timeouts, this causes the connection to be abruptly closed once the NAT
tunnel is re-opened by the client's PING, instead of receiving the
response.

Merge internal change: 133030062

https://codereview.chromium.org/2349373002/

Add method QuicBufferedPacketStore::DiscardPackets

This CL adds a method to QuicBufferedPacketStore to discard all packets
associated with a connection ID.  This functionality will be used where
a CHLO is followed by a bunch of packets which get buffered while the
CHLO is being processed by the stateless rejector logic. If the CHLO is
rejected, the dispatcher will want to drop the buffered packets without
processing them.

Added new method not yet called. No functional change, not
flag-protected.

Merge internal change: 132995934

https://codereview.chromium.org/2351673003/

Fix bizarro comment formatting

Merge internal change: 132917785

https://codereview.chromium.org/2346323003/

Deprecate FLAGS_quic_close_connection_on_packet_too_large.

Merge internal change: 132914520

https://codereview.chromium.org/2352803002/

Deprecate quic_simple_packet_number_length_2.

Merge internal change: 132911786

https://codereview.chromium.org/2354563003/

Deprecate FLAGS_quic_remove_v33_hacks.

Merge internal change: 132908836

https://codereview.chromium.org/2351813002/

Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize.

Merge internal change: 132907311

https://codereview.chromium.org/2350863002/

Deprecate FLAGS_quic_postpone_multipath_flag_validation.

Merge internal change: 132904436

https://codereview.chromium.org/2354673002/

BUG=

Committed: https://crrev.com/1660498884cb6b0f99f77299b304c4703a8b5023
Cr-Commit-Position: refs/heads/master@{#419942}
==========

[commit-bot: I haz the power, 2016-09-21 02:04:41]

Patchset 3 (id:??) landed as
https://crrev.com/1660498884cb6b0f99f77299b304c4703a8b5023
Cr-Commit-Position: refs/heads/master@{#419942}