Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC

net/quic/core/quic_packet_generator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/quic_packet_generator.h"
 
 #include "base/logging.h"
 #include "net/quic/core/quic_bug_tracker.h"
 #include "net/quic/core/quic_flags.h"
 #include "net/quic/core/quic_utils.h"
@@ skipping 177 matching lines @@
   if (retransmittable == HAS_RETRANSMITTABLE_DATA) {
     DCHECK(!queued_control_frames_.empty());  // These are retransmittable.
   }
   return delegate_->ShouldGeneratePacket(retransmittable, NOT_HANDSHAKE);
 }
 
 void QuicPacketGenerator::SendQueuedFrames(bool flush) {
   // Only add pending frames if we are SURE we can then send the whole packet.
   while (HasPendingFrames() &&
          (flush || CanSendWithNextPendingFrameAddition())) {
-    AddNextPendingFrame();
+    if (FLAGS_quic_close_connection_on_huge_frames) {
+      bool first_frame = packet_creator_.CanSetMaxPacketLength();
+      if (!AddNextPendingFrame() && first_frame) {
+        // A single frame cannot fit into the packet, tear down the connection.
+        QUIC_BUG << "A single frame cannot fit into packet."
+                 << " should_send_ack: " << should_send_ack_
+                 << " should_send_stop_waiting: " << should_send_stop_waiting_
+                 << " number of queued_control_frames: "
+                 << queued_control_frames_.size();
+        if (!queued_control_frames_.empty()) {
+          DVLOG(1) << queued_control_frames_[0];
+        }
+        delegate_->OnUnrecoverableError(QUIC_FAILED_TO_SERIALIZE_PACKET,
+                                        "Single frame cannot fit into a packet",
+                                        ConnectionCloseSource::FROM_SELF);
+        return;
+      }
+    } else {
+      AddNextPendingFrame();
+    }
   }
   if (flush || !InBatchMode()) {
     packet_creator_.Flush();
   }
 }
 
 bool QuicPacketGenerator::InBatchMode() {
   return batch_mode_;
 }
 
@@ skipping 110 matching lines @@
 
 void QuicPacketGenerator::SetCurrentPath(
     QuicPathId path_id,
     QuicPacketNumber least_packet_awaited_by_peer,
     QuicPacketCount max_packets_in_flight) {
   packet_creator_.SetCurrentPath(path_id, least_packet_awaited_by_peer,
                                  max_packets_in_flight);
 }
 
 }  // namespace net