Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 2359503003: Landing Recent QUIC changes until 9:58 AM, Sep 17, 2016 UTC (Closed)
Patch Set: Reverted flag flip. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_packet_creator_peer.cc ('k') | net/tools/quic/stateless_rejector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index 61ed2920b816f4b93ab84551662ed79159611946..869eab2de220f79991757bd0c17a963fa45bed5a 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -287,12 +287,12 @@ vector<TestParams> GetTestParams() {
} // End of version for loop.
} // End of 2nd version for loop.
} // End of small_client_mtu loop.
- } // End of buffer_packet_till_chlo loop.
- } // End of use_cheap_stateless_reject for loop.
- } // End of force_hol_blocking loop.
- } // End of disable_hpack_dynamic_table for loop.
- } // End of congestion_control_tag for loop.
- } // End of client_supports_stateless_rejects for loop.
+ } // End of buffer_packet_till_chlo loop.
+ } // End of use_cheap_stateless_reject for loop.
+ } // End of force_hol_blocking loop.
+ } // End of disable_hpack_dynamic_table for loop.
+ } // End of congestion_control_tag for loop.
+ } // End of client_supports_stateless_rejects for loop.
CHECK_EQ(kMaxEnabledOptions, max_enabled_options);
} // End of server_uses_stateless_rejects_if_peer_supported for loop.
return params;
@@ -1359,7 +1359,9 @@ TEST_P(EndToEndTest, NegotiateCongestionControl) {
expected_congestion_control_type = kReno;
break;
case kTBBR:
- expected_congestion_control_type = kBBR;
+ // TODO(vasilvv): switch this back to kBBR when new BBR implementation is
+ // in.
+ expected_congestion_control_type = kCubic;
break;
case kQBIC:
expected_congestion_control_type = kCubic;
@@ -2766,7 +2768,10 @@ TEST_P(EndToEndTestServerPush, ServerPushOverLimitWithBlocking) {
EXPECT_EQ(12u, client_->num_responses());
}
+// TODO(ckrasic) - remove this when deprecating
+// FLAGS_quic_enable_server_push_by_default.
TEST_P(EndToEndTestServerPush, DisabledWithoutConnectionOption) {
+ FLAGS_quic_enable_server_push_by_default = false;
// Tests that server push won't be triggered when kSPSH is not set by client.
support_server_push_ = false;
ASSERT_TRUE(Initialize());
« no previous file with comments | « net/quic/test_tools/quic_packet_creator_peer.cc ('k') | net/tools/quic/stateless_rejector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698