Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 235933002: Defer updateCompositingRequirementsState until the compositing update (Closed)

Created:
6 years, 8 months ago by abarth-chromium
Modified:
6 years, 8 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink, esprehn, ojan, Ian Vollick
Visibility:
Public.

Description

Defer updateCompositingRequirementsState until the compositing update This CL removes some compositing chicken/egg work by deferring updateCompositingRequirementsState until the compositing update. This CL is the first step towards properly integrating this work with the rest of the compositing update. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171398

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : Add DeprecatedDirtyCompositingDuringCompositingUpdate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M LayoutTests/compositing/overflow/overflow-scroll.html View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
abarth-chromium
6 years, 8 months ago (2014-04-11 21:05:21 UTC) #1
Ian Vollick
lgtm w/ minor question. https://codereview.chromium.org/235933002/diff/1/LayoutTests/compositing/overflow/overflow-scroll.html File LayoutTests/compositing/overflow/overflow-scroll.html (right): https://codereview.chromium.org/235933002/diff/1/LayoutTests/compositing/overflow/overflow-scroll.html#newcode39 LayoutTests/compositing/overflow/overflow-scroll.html:39: setTimeout(function() { why the timeout? ...
6 years, 8 months ago (2014-04-11 21:09:36 UTC) #2
abarth-chromium
On 2014/04/11 21:09:36, Ian Vollick wrote: > why the timeout? could you use internals.forceCompositingUpdate? Yes, ...
6 years, 8 months ago (2014-04-11 21:54:11 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-11 22:07:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/235933002/20001
6 years, 8 months ago (2014-04-11 22:07:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 22:21:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-11 22:21:41 UTC) #7
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-11 23:05:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/235933002/20001
6 years, 8 months ago (2014-04-11 23:05:17 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 23:20:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-11 23:20:36 UTC) #11
abarth-chromium
Sadly, that ASSERT failure represents a real problem. This CL will require more study.
6 years, 8 months ago (2014-04-11 23:41:16 UTC) #12
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-12 18:55:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/235933002/40001
6 years, 8 months ago (2014-04-12 18:56:05 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-12 20:40:59 UTC) #15
Message was sent while issue was closed.
Change committed as 171398

Powered by Google App Engine
This is Rietveld 408576698