Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: Source/core/rendering/compositing/RenderLayerCompositor.cpp

Issue 235933002: Defer updateCompositingRequirementsState until the compositing update (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add DeprecatedDirtyCompositingDuringCompositingUpdate Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 bool RenderLayerCompositor::hasUnresolvedDirtyBits() 351 bool RenderLayerCompositor::hasUnresolvedDirtyBits()
352 { 352 {
353 return m_needsToRecomputeCompositingRequirements || m_compositingLayersNeedR ebuild || m_needsUpdateCompositingRequirementsState || m_pendingUpdateType > Com positingUpdateNone; 353 return m_needsToRecomputeCompositingRequirements || m_compositingLayersNeedR ebuild || m_needsUpdateCompositingRequirementsState || m_pendingUpdateType > Com positingUpdateNone;
354 } 354 }
355 355
356 void RenderLayerCompositor::updateIfNeeded() 356 void RenderLayerCompositor::updateIfNeeded()
357 { 357 {
358 if (m_forceCompositingMode && !m_compositing) 358 if (m_forceCompositingMode && !m_compositing)
359 enableCompositingMode(true); 359 enableCompositingMode(true);
360 360
361 {
362 // Notice that we call this function before checking the dirty bits belo w.
363 // We'll need to remove DeprecatedDirtyCompositingDuringCompositingUpdat e
364 // before moving this function after checking the dirty bits.
365 DeprecatedDirtyCompositingDuringCompositingUpdate marker(lifecycle());
366 updateCompositingRequirementsState();
367 }
368
361 if (!m_needsToRecomputeCompositingRequirements && !m_compositing) 369 if (!m_needsToRecomputeCompositingRequirements && !m_compositing)
362 return; 370 return;
363 371
364 CompositingUpdateType updateType = m_pendingUpdateType; 372 CompositingUpdateType updateType = m_pendingUpdateType;
365 373
366 bool needCompositingRequirementsUpdate = m_needsToRecomputeCompositingRequir ements; 374 bool needCompositingRequirementsUpdate = m_needsToRecomputeCompositingRequir ements;
367 bool needHierarchyAndGeometryUpdate = m_compositingLayersNeedRebuild; 375 bool needHierarchyAndGeometryUpdate = m_compositingLayersNeedRebuild;
368 bool needsToUpdateScrollingCoordinator = scrollingCoordinator() ? scrollingC oordinator()->needsToUpdateAfterCompositingChange() : false; 376 bool needsToUpdateScrollingCoordinator = scrollingCoordinator() ? scrollingC oordinator()->needsToUpdateAfterCompositingChange() : false;
369 377
370 if (updateType == CompositingUpdateNone && !needCompositingRequirementsUpdat e && !needHierarchyAndGeometryUpdate && !needsToUpdateScrollingCoordinator) 378 if (updateType == CompositingUpdateNone && !needCompositingRequirementsUpdat e && !needHierarchyAndGeometryUpdate && !needsToUpdateScrollingCoordinator)
(...skipping 1341 matching lines...) Expand 10 before | Expand all | Expand 10 after
1712 } else if (graphicsLayer == m_scrollLayer.get()) { 1720 } else if (graphicsLayer == m_scrollLayer.get()) {
1713 name = "LocalFrame Scrolling Layer"; 1721 name = "LocalFrame Scrolling Layer";
1714 } else { 1722 } else {
1715 ASSERT_NOT_REACHED(); 1723 ASSERT_NOT_REACHED();
1716 } 1724 }
1717 1725
1718 return name; 1726 return name;
1719 } 1727 }
1720 1728
1721 } // namespace WebCore 1729 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/FrameView.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698