Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 235933002: Defer updateCompositingRequirementsState until the compositing update (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add DeprecatedDirtyCompositingDuringCompositingUpdate Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 return; 620 return;
621 621
622 // If we expect to update compositing after an incipient layout, don't do so here. 622 // If we expect to update compositing after an incipient layout, don't do so here.
623 if (m_doingPreLayoutStyleUpdate || layoutPending() || renderView->needsLayou t()) 623 if (m_doingPreLayoutStyleUpdate || layoutPending() || renderView->needsLayou t())
624 return; 624 return;
625 625
626 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues 626 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues
627 // https://code.google.com/p/chromium/issues/detail?id=343756 627 // https://code.google.com/p/chromium/issues/detail?id=343756
628 DisableCompositingQueryAsserts disabler; 628 DisableCompositingQueryAsserts disabler;
629 629
630 // Sometimes we will change a property (for example, z-index) that will not
631 // cause a layout, but will require us to update compositing state. We only
632 // need to do this if a layout is not already scheduled.
633 if (!needsLayout())
634 renderView->compositor()->updateCompositingRequirementsState();
635
636 renderView->compositor()->setNeedsCompositingUpdate(CompositingUpdateAfterSt yleChange); 630 renderView->compositor()->setNeedsCompositingUpdate(CompositingUpdateAfterSt yleChange);
637 } 631 }
638 632
639 void FrameView::updateCompositingLayersAfterLayout() 633 void FrameView::updateCompositingLayersAfterLayout()
640 { 634 {
641 TRACE_EVENT0("webkit", "FrameView::updateCompositingLayersAfterLayout"); 635 TRACE_EVENT0("webkit", "FrameView::updateCompositingLayersAfterLayout");
642 RenderView* renderView = this->renderView(); 636 RenderView* renderView = this->renderView();
643 if (!renderView) 637 if (!renderView)
644 return; 638 return;
645 639
646 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues 640 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues
647 // https://code.google.com/p/chromium/issues/detail?id=343756 641 // https://code.google.com/p/chromium/issues/detail?id=343756
648 DisableCompositingQueryAsserts disabler; 642 DisableCompositingQueryAsserts disabler;
649 643
650 renderView->compositor()->updateForceCompositingMode(); 644 renderView->compositor()->updateForceCompositingMode();
651 renderView->compositor()->updateCompositingRequirementsState();
652 renderView->compositor()->setNeedsCompositingUpdate(CompositingUpdateAfterLa yout); 645 renderView->compositor()->setNeedsCompositingUpdate(CompositingUpdateAfterLa yout);
653 } 646 }
654 647
655 bool FrameView::usesCompositedScrolling() const 648 bool FrameView::usesCompositedScrolling() const
656 { 649 {
657 RenderView* renderView = this->renderView(); 650 RenderView* renderView = this->renderView();
658 if (!renderView) 651 if (!renderView)
659 return false; 652 return false;
660 if (m_frame->settings() && m_frame->settings()->compositedScrollingForFrames Enabled()) 653 if (m_frame->settings() && m_frame->settings()->compositedScrollingForFrames Enabled())
661 return renderView->compositor()->inForcedCompositingMode(); 654 return renderView->compositor()->inForcedCompositingMode();
(...skipping 2549 matching lines...) Expand 10 before | Expand all | Expand 10 after
3211 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) 3204 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation)
3212 { 3205 {
3213 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); 3206 ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
3214 if (AXObjectCache* cache = axObjectCache()) { 3207 if (AXObjectCache* cache = axObjectCache()) {
3215 cache->remove(scrollbar); 3208 cache->remove(scrollbar);
3216 cache->handleScrollbarUpdate(this); 3209 cache->handleScrollbarUpdate(this);
3217 } 3210 }
3218 } 3211 }
3219 3212
3220 } // namespace WebCore 3213 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/compositing/overflow/overflow-scroll.html ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698