Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2359243003: Fix memory leaks in lcms (Closed)

Created:
4 years, 3 months ago by kcwu
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix memory leaks in lcms found by libfuzzer Committed: https://pdfium.googlesource.com/pdfium/+/39ee9dfac1c6d286a4075c7e2435fe1cfe365bad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -8 lines) Patch
A third_party/lcms2-2.6/0004-memory-leak-Type_Curve_Read.patch View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/lcms2-2.6/0005-memory-leak-AllocEmptyTransform.patch View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/lcms2-2.6/0006-memory-leak-Type_NamedColor_Read.patch View 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/lcms2-2.6/0007-memory-leak-OptimizeByResampling.patch View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/README.pdfium View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/src/cmsopt.c View 1 chunk +1 line, -1 line 0 comments Download
M third_party/lcms2-2.6/src/cmstypes.c View 4 chunks +10 lines, -4 lines 0 comments Download
M third_party/lcms2-2.6/src/cmsxform.c View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kcwu
PTAL. My pending pull requests to upstream. https://github.com/mm2/Little-CMS/pull/98 https://github.com/mm2/Little-CMS/pull/99 https://github.com/mm2/Little-CMS/pull/100 https://github.com/mm2/Little-CMS/pull/101 Let me know if ...
4 years, 3 months ago (2016-09-22 19:03:02 UTC) #3
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-22 19:28:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2359243003/20001
4 years, 3 months ago (2016-09-23 01:16:09 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 01:26:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/39ee9dfac1c6d286a4075c7e2435fe1cfe36...

Powered by Google App Engine
This is Rietveld 408576698