third_party/lcms2-2.6/0006-memory-leak-Type_NamedColor_Read.patch - Issue 2359243003: Fix memory leaks in lcms

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/lcms2-2.6/0006-memory-leak-Type_NamedColor_Read.patch

Issue 2359243003: Fix memory leaks in lcms (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/lcms2-2.6/src/cmstypes.c b/third_party/lcms2-2.6/src/cm stypes.c

	2 index feba387..4d24fc2 100644

	3 --- a/third_party/lcms2-2.6/src/cmstypes.c

	4 +++ b/third_party/lcms2-2.6/src/cmstypes.c

	5 @@ -3102,7 +3102,7 @@ void Type_NamedColor_Read(struct _cms_typehandler_struct self, cmsIOHANDLER* i

	6

	7 if (nDeviceCoords > cmsMAXCHANNELS) {

	8 cmsSignalError(self->ContextID, cmsERROR_RANGE, "Too many device coordi nates '%d'", nDeviceCoords);

	9 - return 0;

	10 + goto Error;

	11 }

	12 for (i=0; i < count; i++) {

	13

	14 @@ -3111,7 +3111,7 @@ void Type_NamedColor_Read(struct _cms_typehandler_struct self, cmsIOHANDLER* i

	15 char Root[33];

	16

	17 memset(Colorant, 0, sizeof(Colorant));

	18 - if (io -> Read(io, Root, 32, 1) != 1) return NULL;

	19 + if (io -> Read(io, Root, 32, 1) != 1) goto Error;

	20 Root[32] = 0;

	21 if (!_cmsReadUInt16Array(io, 3, PCS)) goto Error;

	22 if (!_cmsReadUInt16Array(io, nDeviceCoords, Colorant)) goto Error;

OLD	NEW