Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/lcms2-2.6/0004-memory-leak-Type_Curve_Read.patch

Issue 2359243003: Fix memory leaks in lcms (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/lcms2-2.6/0005-memory-leak-AllocEmptyTransform.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/lcms2-2.6/0004-memory-leak-Type_Curve_Read.patch
diff --git a/third_party/lcms2-2.6/0004-memory-leak-Type_Curve_Read.patch b/third_party/lcms2-2.6/0004-memory-leak-Type_Curve_Read.patch
new file mode 100644
index 0000000000000000000000000000000000000000..341a1c6b47cac9727669b6ebe5c618044456ee15
--- /dev/null
+++ b/third_party/lcms2-2.6/0004-memory-leak-Type_Curve_Read.patch
@@ -0,0 +1,28 @@
+diff --git a/third_party/lcms2-2.6/src/cmstypes.c b/third_party/lcms2-2.6/src/cmstypes.c
+index 06742b5..9fe5e2a 100644
+--- a/third_party/lcms2-2.6/src/cmstypes.c
++++ b/third_party/lcms2-2.6/src/cmstypes.c
+@@ -1112,7 +1112,10 @@ void *Type_Curve_Read(struct _cms_typehandler_struct* self, cmsIOHANDLER* io, cm
+ NewGamma = cmsBuildTabulatedToneCurve16(self ->ContextID, Count, NULL);
+ if (!NewGamma) return NULL;
+
+- if (!_cmsReadUInt16Array(io, Count, NewGamma -> Table16)) return NULL;
++ if (!_cmsReadUInt16Array(io, Count, NewGamma -> Table16)) {
++ cmsFreeToneCurve(NewGamma);
++ return NULL;
++ }
+
+ *nItems = 1;
+ return NewGamma;
+@@ -2350,7 +2353,10 @@ cmsStage* ReadCLUT(struct _cms_typehandler_struct* self, cmsIOHANDLER* io, cmsUI
+
+ for (i=0; i < Data ->nEntries; i++) {
+
+- if (io ->Read(io, &v, sizeof(cmsUInt8Number), 1) != 1) return NULL;
++ if (io ->Read(io, &v, sizeof(cmsUInt8Number), 1) != 1) {
++ cmsStageFree(CLUT);
++ return NULL;
++ }
+ Data ->Tab.T[i] = FROM_8_TO_16(v);
+ }
+
« no previous file with comments | « no previous file | third_party/lcms2-2.6/0005-memory-leak-AllocEmptyTransform.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698