Enforce capability spec renderer <--> browser

Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll need to list it in the manifest. I wonder how we should broadcast this. Also as a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Committed: https://crrev.com/c70c0e365340a5426fa1f68f0f8c7008cb94bf5e
Cr-Original-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Original-Commit-Position: refs/heads/master@{#418988}
Cr-Commit-Position: refs/heads/master@{#420257}

[Ben Goodger (Google), 2016-08-18 18:11:00]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 18:11:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 18:20:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 18:20:06]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2016-08-19 18:06:54]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 18:07:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 18:15:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 18:15:15]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2016-09-08 21:27:35]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:27:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 21:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 21:35:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Ben Goodger (Google), 2016-09-08 23:08:22]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 23:08:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:16:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:16:57]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2016-09-08 23:42:48]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 23:43:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:50:58]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2016-09-09 21:58:30]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 21:58:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 22:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 22:52:47]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2016-09-09 23:11:19]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 23:11:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-09-09 23:12:14]

Description was changed from

==========
Enforce capability spec renderer <--> browser

BUG=
==========

to

==========
Enforce capability spec renderer <--> browser
==========

[Ben Goodger (Google), 2016-09-09 23:12:15]

ben@chromium.org changed reviewers:
+ rockot@chromium.org, tsepez@chromium.org

[Ben Goodger (Google), 2016-09-09 23:15:55]

Description was changed from

==========
Enforce capability spec renderer <--> browser
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-09-09 23:26:41]

lgtm

https://codereview.chromium.org/2259903002/diff/140001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2259903002/diff/140001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_client.cc:2974: if (name ==
"exe:content_browser")
Hmm. Guess we should move the constants from content/common to
content/public/common

[commit-bot: I haz the power, 2016-09-10 00:38:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:38:58]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-12 16:53:16]

https://codereview.chromium.org/2259903002/diff/140001/chrome/browser/content...
File chrome/browser/content_browser_manifest_overlay.json (right):

https://codereview.chromium.org/2259903002/diff/140001/chrome/browser/content...
chrome/browser/content_browser_manifest_overlay.json:1: {
Can we update the OWNERS file to list the security team as this file's owners?

https://codereview.chromium.org/2259903002/diff/140001/content/browser/mojo/m...
File content/browser/mojo/mojo_shell_context.cc (right):

https://codereview.chromium.org/2259903002/diff/140001/content/browser/mojo/m...
content/browser/mojo/mojo_shell_context.cc:105: void
MergeDictionary(base::DictionaryValue* target,
Nit: Maybe this should be a base::DictionaryValue method.  I wonder how many
other places we do something like this in the codbase?

[Tom Sepez, 2016-09-12 16:54:27]

https://codereview.chromium.org/2259903002/diff/140001/content/browser/mojo/m...
File content/browser/mojo/mojo_shell_context.cc (right):

https://codereview.chromium.org/2259903002/diff/140001/content/browser/mojo/m...
content/browser/mojo/mojo_shell_context.cc:105: void
MergeDictionary(base::DictionaryValue* target,
On 2016/09/12 16:53:16, Tom Sepez (ooo 9 sept) wrote:
> Nit: Maybe this should be a base::DictionaryValue method.  I wonder how many
> other places we do something like this in the codbase?
Can we write a unit test for this?  Might be easier to do so if it were in base?

[Ben Goodger (Google), 2016-09-12 18:11:55]

On 2016/09/12 16:53:16, Tom Sepez wrote:
https://codereview.chromium.org/2259903002/diff/140001/content/browser/mojo/m...
> content/browser/mojo/mojo_shell_context.cc:105: void
> MergeDictionary(base::DictionaryValue* target,
> Nit: Maybe this should be a base::DictionaryValue method.  I wonder how many
> other places we do something like this in the codbase?

I had this same thought, ran it by brettw & rockot and got this range of
feedback:

"base::Value is a trainwreck"
"don't add this to base"
"just implement this functionality locally"

[Ben Goodger (Google), 2016-09-12 18:19:45]

On 2016/09/12 18:11:55, Ben Goodger (Google) wrote:
> On 2016/09/12 16:53:16, Tom Sepez wrote:
>
https://codereview.chromium.org/2259903002/diff/140001/content/browser/mojo/m...
> > content/browser/mojo/mojo_shell_context.cc:105: void
> > MergeDictionary(base::DictionaryValue* target,
> > Nit: Maybe this should be a base::DictionaryValue method.  I wonder how many
> > other places we do something like this in the codbase?
> 
> I had this same thought, ran it by brettw & rockot and got this range of
> feedback:
> 
> "base::Value is a trainwreck"
> "don't add this to base"
> "just implement this functionality locally"

I'll split this function into a separate file here & write a unit test for it.
Separately, I'm asking Brett to ponder how to make base::Value not be a
trainwreck.

[Ben Goodger (Google), 2016-09-12 23:34:30]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 23:34:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-09-12 23:37:19]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[Ben Goodger (Google), 2016-09-12 23:37:40]

On 2016/09/12 18:19:45, Ben Goodger (Google) wrote:
> On 2016/09/12 18:11:55, Ben Goodger (Google) wrote:
> > On 2016/09/12 16:53:16, Tom Sepez wrote:
> >
>
https://codereview.chromium.org/2259903002/diff/140001/content/browser/mojo/m...
> > > content/browser/mojo/mojo_shell_context.cc:105: void
> > > MergeDictionary(base::DictionaryValue* target,
> > > Nit: Maybe this should be a base::DictionaryValue method.  I wonder how
many
> > > other places we do something like this in the codbase?
> > 
> > I had this same thought, ran it by brettw & rockot and got this range of
> > feedback:
> > 
> > "base::Value is a trainwreck"
> > "don't add this to base"
> > "just implement this functionality locally"
> 
> I'll split this function into a separate file here & write a unit test for it.
> Separately, I'm asking Brett to ponder how to make base::Value not be a
> trainwreck.

OK, unit test added (see content/browser/mojo/merge_dictionary_unittest.cc).

[commit-bot: I haz the power, 2016-09-12 23:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:51:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:52:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-09-13 00:02:24]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 00:03:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 01:10:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 01:10:54]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-13 16:19:31]

Very nice, I think this will make things better even in a world where the trains
stay on the tracks. LGTM.

[Ben Goodger (Google), 2016-09-13 17:18:41]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-09-13 17:18:41]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2259903002/#ps200001
(title: ".")

[commit-bot: I haz the power, 2016-09-13 17:19:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 17:24:33]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org
==========

[commit-bot: I haz the power, 2016-09-13 17:24:35]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-09-13 17:26:15]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Cr-Commit-Position: refs/heads/master@{#418282}
==========

[commit-bot: I haz the power, 2016-09-13 17:26:17]

Patchset 11 (id:??) landed as
https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Cr-Commit-Position: refs/heads/master@{#418282}

[lazyboy, 2016-09-13 18:29:52]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/2339593002/ by lazyboy@chromium.org.

The reason for reverting is: This breaks cast linux bot:
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux

content_unittests/MergeDictionaryTest.Merge crashing:

e.g.
https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/3144...


Received signal 11 SEGV_MAPERR 000000000018
#0 0x000002aa5b67 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7fd343c82340 <unknown>
#2 0x000002b03806 base::ListValue::AppendString()
#3 0x0000022f9abf content::MergeDictionary()
#4 0x000000c912da content::MergeDictionaryTest_Merge_Test::TestBody()
#5 0x00000291c547 testing::Test::Run()
#6 0x00000291d203 testing::TestInfo::Run()
#7 0x00000291d697 testing::TestCase::Run()
#8 0x0000029246d7 testing::internal::UnitTestImpl::RunAllTests()
#9 0x00000292432a testing::UnitTest::Run()
#10 0x0000024e4ec3 base::TestSuite::Run()
#11 0x0000024f4809 base::(anonymous namespace)::LaunchUnitTestsInternal()
#12 0x0000024f46cb base::LaunchUnitTests()
#13 0x00000137df7f main
#14 0x7fd341479ec5 __libc_start_main
#15 0x00000053229d <unknown>
  r8: 0000000000000003  r9: 0000000000000001 r10: 0000000057d83dcb r11:
00007fd3415de870
 r12: 00007fd341d363f8 r13: 00003fed7ca22840 r14: 0000000000000000 r15:
0000000000000000
  di: 0000000000000018  si: 00007fd341d363f8  bp: 00007fd341d363e0  bx:
00003fed7ca22850
  dx: 0000000000000000  ax: 00007fd341d363f8  cx: 00000000000006e8  sp:
00007fffcb1ae2b0
  ip: 0000000002b03806 efl: 0000000000010202 cgf: 0000000000000033 erf:
0000000000000004
 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000018
[end of stack trace]
[1609/4198] MergeDictionaryTest.Merge (CRASHED).

[Ben Goodger (Google), 2016-09-13 21:33:31]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Cr-Commit-Position: refs/heads/master@{#418282}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Cr-Commit-Position: refs/heads/master@{#418282}
==========

[Ben Goodger (Google), 2016-09-13 21:38:44]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-09-13 21:38:45]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2259903002/#ps220001
(title: ".")

[commit-bot: I haz the power, 2016-09-13 21:39:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:53:22]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Cr-Commit-Position: refs/heads/master@{#418282}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Cr-Commit-Position: refs/heads/master@{#418282}
==========

[commit-bot: I haz the power, 2016-09-13 22:53:24]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-09-13 22:56:00]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Cr-Commit-Position: refs/heads/master@{#418282}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Cr-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Commit-Position: refs/heads/master@{#418398}
==========

[commit-bot: I haz the power, 2016-09-13 22:56:01]

Patchset 12 (id:??) landed as
https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Cr-Commit-Position: refs/heads/master@{#418398}

[lazyboy, 2016-09-13 23:24:37]

On 2016/09/13 22:56:01, commit-bot: I haz the power wrote:
> Patchset 12 (id:??) landed as
> https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
> Cr-Commit-Position: refs/heads/master@{#418398}

This breaks a lot of webkit tests, e.g.:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/7...
(It did last time too)

Several thousands of browser tests failed last time too, not sure about this
one.

[scottmg, 2016-09-13 23:26:11]

On 2016/09/13 23:24:37, lazyboy wrote:
> On 2016/09/13 22:56:01, commit-bot: I haz the power wrote:
> > Patchset 12 (id:??) landed as
> > https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
> > Cr-Commit-Position: refs/heads/master@{#418398}
> 
> This breaks a lot of webkit tests, e.g.:
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/7...
> (It did last time too)
> 
> Several thousands of browser tests failed last time too, not sure about this
> one.

https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigatio...
too both times.

[Ben Goodger (Google), 2016-09-13 23:39:22]

A revert of this CL (patchset #12 id:220001) has been created in
https://codereview.chromium.org/2335423002/ by ben@chromium.org.

The reason for reverting is: broke stuff.

[Ben Goodger (Google), 2016-09-13 23:56:26]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Cr-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Commit-Position: refs/heads/master@{#418398}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Cr-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Commit-Position: refs/heads/master@{#418398}
==========

[Ben Goodger (Google), 2016-09-13 23:57:13]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:57:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:01:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 01:01:10]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2016-09-14 16:22:19]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-09-14 16:22:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2259903002/#ps260001
(title: ".")

[commit-bot: I haz the power, 2016-09-14 16:22:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 16:29:23]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Cr-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Commit-Position: refs/heads/master@{#418398}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Cr-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Commit-Position: refs/heads/master@{#418398}
==========

[commit-bot: I haz the power, 2016-09-14 16:29:25]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-09-14 16:33:31]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Cr-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Commit-Position: refs/heads/master@{#418398}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Commit-Position: refs/heads/master@{#418582}
==========

[commit-bot: I haz the power, 2016-09-14 16:33:33]

Patchset 14 (id:??) landed as
https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Cr-Commit-Position: refs/heads/master@{#418582}

[jbroman, 2016-09-14 17:16:19]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/2341633003/ by jbroman@chromium.org.

The reason for reverting is: Broke broadcastchannel layout tests:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/7...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11.

[msw, 2016-09-14 18:17:40]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/2342523003/ by msw@chromium.org.

The reason for reverting is: Numerous failures; some examples:
https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/bu...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/45903
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/7...

Potentially related:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/28370.

[oystein (OOO til 10th of July), 2016-09-14 20:36:37]

A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/2346593002/ by oysteine@chromium.org.

The reason for reverting is: Introduces crashes in Mojo on all Windows perf
bots: https://bugs.chromium.org/p/chromium/issues/detail?id=647006.

[Ben Goodger (Google), 2016-09-14 21:04:06]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Commit-Position: refs/heads/master@{#418582}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Commit-Position: refs/heads/master@{#418582}
==========

[Ben Goodger (Google), 2016-09-14 21:06:26]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-09-14 21:06:26]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2259903002/#ps280001
(title: ".")

[commit-bot: I haz the power, 2016-09-14 21:07:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 22:06:44]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Commit-Position: refs/heads/master@{#418582}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Commit-Position: refs/heads/master@{#418582}
==========

[commit-bot: I haz the power, 2016-09-14 22:06:46]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2016-09-14 22:10:36]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Cr-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Commit-Position: refs/heads/master@{#418582}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Commit-Position: refs/heads/master@{#418691}
==========

[commit-bot: I haz the power, 2016-09-14 22:10:39]

Patchset 15 (id:??) landed as
https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Cr-Commit-Position: refs/heads/master@{#418691}

[Ken Rockot(use gerrit already), 2016-09-14 22:15:17]

https://codereview.chromium.org/2259903002/diff/280001/content/browser/mojo/m...
File content/browser/mojo/merge_dictionary.cc (right):

https://codereview.chromium.org/2259903002/diff/280001/content/browser/mojo/m...
content/browser/mojo/merge_dictionary.cc:28:
CHECK(target->GetListWithoutPathExpansion(it.key(), &target_list));
Likely this CHECK will be hit, which would explain the nullptr dereferences in
non-DCHECK builds like perf bots.

I don't think you want to CHECK. Rather, you want to fall through to the
deep-copy logic if the list doesn't already exist.

[Ben Goodger (Google), 2016-09-14 22:38:51]

A revert of this CL (patchset #15 id:280001) has been created in
https://codereview.chromium.org/2336043008/ by ben@chromium.org.

The reason for reverting is: This is still broken, as it happens..

[Ben Goodger (Google), 2016-09-14 22:39:21]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Commit-Position: refs/heads/master@{#418691}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Commit-Position: refs/heads/master@{#418691}
==========

[Ben Goodger (Google), 2016-09-15 17:45:26]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 17:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-09-15 18:04:52]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 18:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-09-15 19:52:27]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-09-15 19:52:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2259903002/#ps340001
(title: ".")

[commit-bot: I haz the power, 2016-09-15 19:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-15 20:08:46]

https://codereview.chromium.org/2259903002/diff/340001/content/browser/mojo/m...
File content/browser/mojo/merge_dictionary.cc (right):

https://codereview.chromium.org/2259903002/diff/340001/content/browser/mojo/m...
content/browser/mojo/merge_dictionary.cc:32: CHECK(merge_list->GetString(i,
&value));
Any reason to enforce that every list is only of strings, rather than simply
appending a DeepCopy of every element?

https://codereview.chromium.org/2259903002/diff/340001/content/browser/mojo/m...
content/browser/mojo/merge_dictionary.cc:35: needs_clobber = false;
nit: You could just continue here like you do above for dictionaries?

[Ben Goodger (Google), 2016-09-15 20:30:25]

The CQ bit was unchecked by ben@chromium.org

[Ben Goodger (Google), 2016-09-15 20:31:12]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-09-15 20:31:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2259903002/#ps360001
(title: ".")

[commit-bot: I haz the power, 2016-09-15 20:32:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 21:39:49]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Commit-Position: refs/heads/master@{#418691}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Commit-Position: refs/heads/master@{#418691}
==========

[commit-bot: I haz the power, 2016-09-15 21:39:51]

Committed patchset #19 (id:360001)

[commit-bot: I haz the power, 2016-09-15 21:42:11]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418282}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Commit-Position: refs/heads/master@{#418691}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Cr-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}
==========

[commit-bot: I haz the power, 2016-09-15 21:42:14]

Patchset 19 (id:??) landed as
https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Cr-Commit-Position: refs/heads/master@{#418988}

[tommycli, 2016-09-16 16:40:40]

A revert of this CL (patchset #19 id:360001) has been created in
https://codereview.chromium.org/2346803004/ by tommycli@chromium.org.

The reason for reverting is: Speculative revert to fix breakage here:

https://build.chromium.org/p/chromium.memory.full/builders/Linux%20TSan%20Tes....

[blundell, 2016-09-18 18:49:58]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-09-18 18:49:59]

When you reland this, could you update it with
https://codereview.chromium.org/2340373003/ (adding
device::mojom::TimeZoneMonitor to the browser's "web" set)? Thanks!

[Ben Goodger (Google), 2016-09-21 16:45:23]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Cr-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Cr-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}
==========

[Ben Goodger (Google), 2016-09-21 19:25:03]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:25:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-09-21 19:26:08]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 19:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:42:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2016-09-21 19:49:35]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 20:18:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 20:18:44]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Ben Goodger (Google), 2016-09-21 20:41:30]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ben Goodger (Google), 2016-09-21 20:58:30]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 22:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 22:29:16]

Dry run: This issue passed the CQ dry run.

[Ben Goodger (Google), 2016-09-21 23:00:49]

Ken: mojo_shell_context.cc

[Ken Rockot(use gerrit already), 2016-09-22 00:00:59]

LGTM

[Ben Goodger (Google), 2016-09-22 03:44:30]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-09-22 03:44:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2259903002/#ps460001
(title: ".")

[commit-bot: I haz the power, 2016-09-22 03:44:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 03:51:29]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Cr-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Cr-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}
==========

[commit-bot: I haz the power, 2016-09-22 03:51:32]

Committed patchset #24 (id:460001)

[commit-bot: I haz the power, 2016-09-22 03:54:53]

Description was changed from

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Cr-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418282}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418398}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Commit-Position: refs/heads/master@{#418988}
==========

to

==========
Enforce capability spec renderer <--> browser.

This implements:

- allows the content embedder to merge a manifest into the base ones provided by
content, allowing it to add to the list of interfaces exposed to the renderer.
- adds such an overlay to chrome/browser

So.. from now on if you add an interface to either the browser/renderer, you'll
need to list it in the manifest. I wonder how we should broadcast this. Also as
a separate step we should require these manifests get security review.

R=rockot@chromium.org,tsepez@chromium.org

Committed: https://crrev.com/4ea17059bf78553528f3ffb4a9de84a447622fd3
Committed: https://crrev.com/807a926c9ca02ac8ae1b52e82537834ef78fb9ba
Committed: https://crrev.com/91c25a3cedc4fadcb8c84e91cc59a8f90411058a
Committed: https://crrev.com/cdf40b4b434b43af6accf0c822ea964bc6bfd931
Committed: https://crrev.com/8b277b0bd73aa544f0d5e38a8763658d3e807880
Committed: https://crrev.com/c70c0e365340a5426fa1f68f0f8c7008cb94bf5e
Cr-Original-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418282}
Cr-Original-Original-Original-Original-Commit-Position:
refs/heads/master@{#418398}
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#418582}
Cr-Original-Original-Commit-Position: refs/heads/master@{#418691}
Cr-Original-Commit-Position: refs/heads/master@{#418988}
Cr-Commit-Position: refs/heads/master@{#420257}
==========

[commit-bot: I haz the power, 2016-09-22 03:54:55]

Patchset 24 (id:??) landed as
https://crrev.com/c70c0e365340a5426fa1f68f0f8c7008cb94bf5e
Cr-Commit-Position: refs/heads/master@{#420257}