Remove use of WebCrypto digestSynchronous in Blink.

Remove use of WebCrypto digestSynchronous in Blink.

In the internal WebCrypto API, WebCryptoDigestor can act as a superset of
digestSynchronous. It will simlify things to not have digestSynchronous anymore,
so as a first step, this removes its one use.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171387

[jww, 2014-04-11 23:15:57]

abarth, I think this is a pretty simple CL, except for my use of
ASSERT_WITH_SECURITY_IMPLICATION in WebSocketHandshake.cpp. Let me know if you
think that's overkill.

[abarth-chromium, 2014-04-11 23:26:20]

lgtm

https://codereview.chromium.org/235893003/diff/1/Source/modules/websockets/We...
File Source/modules/websockets/WebSocketHandshake.cpp (right):

https://codereview.chromium.org/235893003/diff/1/Source/modules/websockets/We...
Source/modules/websockets/WebSocketHandshake.cpp:130:
ASSERT_WITH_SECURITY_IMPLICATION(digestSuccess);
Why not just RELEASE_ASSERT ?

[jww, 2014-04-11 23:29:52]

On Fri, Apr 11, 2014 at 4:26 PM, <abarth@chromium.org> wrote:

> lgtm
>
>
>
>
> https://codereview.chromium.org/235893003/diff/1/Source/
> modules/websockets/WebSocketHandshake.cpp
> File Source/modules/websockets/WebSocketHandshake.cpp (right):
>
> https://codereview.chromium.org/235893003/diff/1/Source/
> modules/websockets/WebSocketHandshake.cpp#newcode130
> Source/modules/websockets/WebSocketHandshake.cpp:130:
> ASSERT_WITH_SECURITY_IMPLICATION(digestSuccess);
> Why not just RELEASE_ASSERT ?
>
I guess that makes more sense. I was going by the "SECURITY" in the name,
but a RELEASE_ASSERT should be sufficient it seems :-)

>
> https://codereview.chromium.org/235893003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[jww, 2014-04-11 23:31:27]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2014-04-11 23:31:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jww@chromium.org/235893003/20001

[commit-bot: I haz the power, 2014-04-12 00:37:36]

Change committed as 171387