Source/platform/Crypto.h - Issue 235893003: Remove use of WebCrypto digestSynchronous in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/Crypto.h

Issue 235893003: Remove use of WebCrypto digestSynchronous in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed ASSERT_WITH_SECURITY_IMPLICATIONS to RELEASE_ASSERT Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/Crypto.h

diff --git a/Source/platform/Crypto.h b/Source/platform/Crypto.h

index d5556befa24f7c2e8b6b51bf2b80f62a4b29d253..1ebcd1de84576a52b88e3627416cd68b725d1cab 100644

--- a/Source/platform/Crypto.h

+++ b/Source/platform/Crypto.h

@@ -31,7 +31,7 @@ enum HashAlgorithm {

HashAlgorithmSha512

};

-PLATFORM_EXPORT void computeDigest(HashAlgorithm, const char* digestable, size_t length, DigestValue& digestResult);

+PLATFORM_EXPORT bool computeDigest(HashAlgorithm, const char* digestable, size_t length, DigestValue& digestResult);

PLATFORM_EXPORT PassOwnPtr<blink::WebCryptoDigestor> createDigestor(HashAlgorithm);

PLATFORM_EXPORT void finishDigestor(blink::WebCryptoDigestor*, DigestValue& digestResult);

« no previous file with comments | « Source/modules/websockets/WebSocketHandshake.cpp ('k') | Source/platform/Crypto.cpp » ('j') | no next file with comments »