Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: Source/modules/websockets/WebSocketHandshake.cpp

Issue 235893003: Remove use of WebCrypto digestSynchronous in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed ASSERT_WITH_SECURITY_IMPLICATIONS to RELEASE_ASSERT Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/csp/ContentSecurityPolicy.cpp ('k') | Source/platform/Crypto.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/websockets/WebSocketHandshake.cpp
diff --git a/Source/modules/websockets/WebSocketHandshake.cpp b/Source/modules/websockets/WebSocketHandshake.cpp
index 8def260211d99ec01d31d12fbaff82a571d8c784..f5afeeda620fc213f27fe68ace8c84e9ae6cecc1 100644
--- a/Source/modules/websockets/WebSocketHandshake.cpp
+++ b/Source/modules/websockets/WebSocketHandshake.cpp
@@ -126,7 +126,8 @@ String WebSocketHandshake::getExpectedWebSocketAccept(const String& secWebSocket
digestable.append(webSocketKeyGUID, strlen(webSocketKeyGUID));
CString digestableCString = digestable.toString().utf8();
DigestValue digest;
- computeDigest(HashAlgorithmSha1, digestableCString.data(), digestableCString.length(), digest);
+ bool digestSuccess = computeDigest(HashAlgorithmSha1, digestableCString.data(), digestableCString.length(), digest);
+ RELEASE_ASSERT(digestSuccess);
return base64Encode(reinterpret_cast<const char*>(digest.data()), sha1HashSize);
}
« no previous file with comments | « Source/core/frame/csp/ContentSecurityPolicy.cpp ('k') | Source/platform/Crypto.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698