Remove DIP scale from PopupTouchHandleDrawable

Remove DIP scale from PopupTouchHandleDrawable

Now the native part of PopupTouchHandleDrawable always
operates in DIP coordinates. The Java part converts
from pixels to DIP using the device scale factor which
it obtains from ContentViewCore.

BUG=620929
Committed: https://crrev.com/95096567989c7a4f1b96d31a1c45d5c2dc8f8abb
Cr-Commit-Position: refs/heads/master@{#420198}

[Tima Vaisburd, 2016-09-21 18:58:32]

timav@chromium.org changed reviewers:
+ boliu@chromium.org

[Tima Vaisburd, 2016-09-21 18:58:33]

PTAL.

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
File
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java
(right):

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java:498:
private float getOriginXDip() {
Shall we have one method that would return a rectangle instead?

[Tima Vaisburd, 2016-09-21 19:01:11]

The CQ bit was checked by timav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:02:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 19:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:24:54]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-09-21 20:12:33]

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
File
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java
(right):

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java:262:
return new Point(mParentPositionX + (int) (mOriginXDip * deviceScale),
hmm.....can you not new a java object every time this is called? easiest way
might just be keep the two things separate so you can keep using ints

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java:483:
// TODO: Do we need to invalidate if pixel position changes because of DIP scale
change?
huh?

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java:498:
private float getOriginXDip() {
On 2016/09/21 18:58:32, Tima Vaisburd wrote:
> Shall we have one method that would return a rectangle instead?

No

[Tima Vaisburd, 2016-09-21 21:37:10]

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
File
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java
(right):

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java:262:
return new Point(mParentPositionX + (int) (mOriginXDip * deviceScale),
On 2016/09/21 20:12:33, boliu wrote:
> hmm.....can you not new a java object every time this is called? easiest way
> might just be keep the two things separate so you can keep using ints

Returned to two methods for X and Y, as before.

https://codereview.chromium.org/2358893002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java:483:
// TODO: Do we need to invalidate if pixel position changes because of DIP scale
change?
On 2016/09/21 20:12:33, boliu wrote:
> huh?

Comment removed.

[boliu, 2016-09-21 23:01:28]

lgtm

[Tima Vaisburd, 2016-09-21 23:02:50]

The CQ bit was checked by timav@chromium.org

[commit-bot: I haz the power, 2016-09-21 23:03:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:34:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-22 00:31:13]

Description was changed from

==========
Remove DIP scale from PopupTouchHandleDrawable

Now the native part of PopupTouchHandleDrawable always
operates in DIP coordinates. The Java part converts
from pixels to DIP using the device scale factor which
it obtains from ContentViewCore.

BUG=620929
==========

to

==========
Remove DIP scale from PopupTouchHandleDrawable

Now the native part of PopupTouchHandleDrawable always
operates in DIP coordinates. The Java part converts
from pixels to DIP using the device scale factor which
it obtains from ContentViewCore.

BUG=620929

Committed: https://crrev.com/95096567989c7a4f1b96d31a1c45d5c2dc8f8abb
Cr-Commit-Position: refs/heads/master@{#420198}
==========

[commit-bot: I haz the power, 2016-09-22 00:31:14]

Patchset 3 (id:??) landed as
https://crrev.com/95096567989c7a4f1b96d31a1c45d5c2dc8f8abb
Cr-Commit-Position: refs/heads/master@{#420198}