Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Side by Side Diff: android_webview/native/popup_touch_handle_drawable.h

Issue 2358893002: Remove DIP scale from PopupTouchHandleDrawable (Closed)
Patch Set: Fixed formatting Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_POPUP_TOUCH_HANDLE_DRAWABLE_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_POPUP_TOUCH_HANDLE_DRAWABLE_H_
6 #define CONTENT_BROWSER_ANDROID_POPUP_TOUCH_HANDLE_DRAWABLE_H_ 6 #define CONTENT_BROWSER_ANDROID_POPUP_TOUCH_HANDLE_DRAWABLE_H_
7 7
8 #include "ui/touch_selection/touch_handle.h" 8 #include "ui/touch_selection/touch_handle.h"
9 9
10 #include <memory> 10 #include <memory>
11 11
12 #include "base/android/jni_android.h" 12 #include "base/android/jni_android.h"
13 #include "base/android/jni_weak_ref.h" 13 #include "base/android/jni_weak_ref.h"
14 #include "base/macros.h" 14 #include "base/macros.h"
15 15
16 namespace android_webview { 16 namespace android_webview {
17 17
18 // Touch handle drawable backed by an Android PopupWindow. 18 // Touch handle drawable backed by an Android PopupWindow.
19 class PopupTouchHandleDrawable : public ui::TouchHandleDrawable { 19 class PopupTouchHandleDrawable : public ui::TouchHandleDrawable {
20 public: 20 public:
21 PopupTouchHandleDrawable(JNIEnv* env, jobject obj, float dpi_scale, 21 PopupTouchHandleDrawable(JNIEnv* env,
22 float horizontal_padding_ratio); 22 jobject obj,
23 float horizontal_padding_ratio);
23 ~PopupTouchHandleDrawable() override; 24 ~PopupTouchHandleDrawable() override;
24 25
25 static bool RegisterPopupTouchHandleDrawable(JNIEnv* env); 26 static bool RegisterPopupTouchHandleDrawable(JNIEnv* env);
26 27
27 // ui::TouchHandleDrawable implementation. 28 // ui::TouchHandleDrawable implementation.
28 void SetEnabled(bool enabled) override; 29 void SetEnabled(bool enabled) override;
29 void SetOrientation(ui::TouchHandleOrientation orientation, 30 void SetOrientation(ui::TouchHandleOrientation orientation,
30 bool mirror_vertical, 31 bool mirror_vertical,
31 bool mirror_horizontal) override; 32 bool mirror_horizontal) override;
32 void SetOrigin(const gfx::PointF& origin) override; 33 void SetOrigin(const gfx::PointF& origin) override;
33 void SetAlpha(float alpha) override; 34 void SetAlpha(float alpha) override;
34 gfx::RectF GetVisibleBounds() const override; 35 gfx::RectF GetVisibleBounds() const override;
35 float GetDrawableHorizontalPaddingRatio() const override; 36 float GetDrawableHorizontalPaddingRatio() const override;
36 37
37 private: 38 private:
38 39
39 JavaObjectWeakGlobalRef java_ref_; 40 JavaObjectWeakGlobalRef java_ref_;
40 41
41 const float dip_scale_;
42 const float drawable_horizontal_padding_ratio_; 42 const float drawable_horizontal_padding_ratio_;
43 43
44 DISALLOW_COPY_AND_ASSIGN(PopupTouchHandleDrawable); 44 DISALLOW_COPY_AND_ASSIGN(PopupTouchHandleDrawable);
45 }; 45 };
46 46
47 } // namespace content 47 } // namespace content
48 48
49 #endif // CONTENT_BROWSER_ANDROID_POPUP_TOUCH_HANDLE_DRAWABLE_H_ 49 #endif // CONTENT_BROWSER_ANDROID_POPUP_TOUCH_HANDLE_DRAWABLE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698