Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: android_webview/native/popup_touch_handle_drawable.cc

Issue 2358893002: Remove DIP scale from PopupTouchHandleDrawable (Closed)
Patch Set: Fixed formatting Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/native/popup_touch_handle_drawable.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/popup_touch_handle_drawable.h" 5 #include "android_webview/native/popup_touch_handle_drawable.h"
6 6
7 #include "jni/PopupTouchHandleDrawable_jni.h" 7 #include "jni/PopupTouchHandleDrawable_jni.h"
8 8
9 using base::android::JavaParamRef; 9 using base::android::JavaParamRef;
10 using base::android::ScopedJavaLocalRef; 10 using base::android::ScopedJavaLocalRef;
11 11
12 namespace android_webview { 12 namespace android_webview {
13 13
14 PopupTouchHandleDrawable::PopupTouchHandleDrawable( 14 PopupTouchHandleDrawable::PopupTouchHandleDrawable(
15 JNIEnv* env, 15 JNIEnv* env,
16 jobject obj, 16 jobject obj,
17 float dip_scale,
18 float horizontal_padding_ratio) 17 float horizontal_padding_ratio)
19 : java_ref_(env, obj) 18 : java_ref_(env, obj)
20 , dip_scale_(dip_scale)
21 , drawable_horizontal_padding_ratio_(horizontal_padding_ratio) { 19 , drawable_horizontal_padding_ratio_(horizontal_padding_ratio) {
22 DCHECK(!java_ref_.is_empty()); 20 DCHECK(!java_ref_.is_empty());
23 } 21 }
24 22
25 PopupTouchHandleDrawable::~PopupTouchHandleDrawable() { 23 PopupTouchHandleDrawable::~PopupTouchHandleDrawable() {
26 JNIEnv* env = base::android::AttachCurrentThread(); 24 JNIEnv* env = base::android::AttachCurrentThread();
27 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env); 25 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
28 if (!obj.is_null()) 26 if (!obj.is_null())
29 Java_PopupTouchHandleDrawable_destroy(env, obj); 27 Java_PopupTouchHandleDrawable_destroy(env, obj);
30 } 28 }
(...skipping 23 matching lines...) Expand all
54 Java_PopupTouchHandleDrawable_setOrientation( 52 Java_PopupTouchHandleDrawable_setOrientation(
55 env, obj, static_cast<int>(orientation), mirror_vertical, 53 env, obj, static_cast<int>(orientation), mirror_vertical,
56 mirror_horizontal); 54 mirror_horizontal);
57 } 55 }
58 } 56 }
59 57
60 void PopupTouchHandleDrawable::SetOrigin(const gfx::PointF& origin) { 58 void PopupTouchHandleDrawable::SetOrigin(const gfx::PointF& origin) {
61 JNIEnv* env = base::android::AttachCurrentThread(); 59 JNIEnv* env = base::android::AttachCurrentThread();
62 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env); 60 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
63 if (!obj.is_null()) { 61 if (!obj.is_null()) {
64 const gfx::PointF origin_pix = gfx::ScalePoint(origin, dip_scale_); 62 Java_PopupTouchHandleDrawable_setOrigin(env, obj, origin.x(), origin.y());
65 Java_PopupTouchHandleDrawable_setOrigin(env, obj, origin_pix.x(),
66 origin_pix.y());
67 } 63 }
68 } 64 }
69 65
70 void PopupTouchHandleDrawable::SetAlpha(float alpha) { 66 void PopupTouchHandleDrawable::SetAlpha(float alpha) {
71 JNIEnv* env = base::android::AttachCurrentThread(); 67 JNIEnv* env = base::android::AttachCurrentThread();
72 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env); 68 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
73 bool visible = alpha > 0; 69 bool visible = alpha > 0;
74 if (!obj.is_null()) 70 if (!obj.is_null())
75 Java_PopupTouchHandleDrawable_setVisible(env, obj, visible); 71 Java_PopupTouchHandleDrawable_setVisible(env, obj, visible);
76 } 72 }
77 73
78 gfx::RectF PopupTouchHandleDrawable::GetVisibleBounds() const { 74 gfx::RectF PopupTouchHandleDrawable::GetVisibleBounds() const {
79 JNIEnv* env = base::android::AttachCurrentThread(); 75 JNIEnv* env = base::android::AttachCurrentThread();
80 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env); 76 ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
81 if (obj.is_null()) 77 if (obj.is_null())
82 return gfx::RectF(); 78 return gfx::RectF();
83 gfx::RectF unscaled_rect( 79 return gfx::RectF(
84 Java_PopupTouchHandleDrawable_getPositionX(env, obj), 80 Java_PopupTouchHandleDrawable_getOriginXDip(env, obj),
85 Java_PopupTouchHandleDrawable_getPositionY(env, obj), 81 Java_PopupTouchHandleDrawable_getOriginYDip(env, obj),
86 Java_PopupTouchHandleDrawable_getVisibleWidth(env, obj), 82 Java_PopupTouchHandleDrawable_getVisibleWidthDip(env, obj),
87 Java_PopupTouchHandleDrawable_getVisibleHeight(env, obj)); 83 Java_PopupTouchHandleDrawable_getVisibleHeightDip(env, obj));
88 return gfx::ScaleRect(unscaled_rect, 1.f / dip_scale_);
89 } 84 }
90 85
91 float PopupTouchHandleDrawable::GetDrawableHorizontalPaddingRatio() const { 86 float PopupTouchHandleDrawable::GetDrawableHorizontalPaddingRatio() const {
92 return drawable_horizontal_padding_ratio_; 87 return drawable_horizontal_padding_ratio_;
93 } 88 }
94 89
95 static jlong Init(JNIEnv* env, 90 static jlong Init(JNIEnv* env,
96 const JavaParamRef<jobject>& obj, 91 const JavaParamRef<jobject>& obj,
97 const JavaParamRef<jobject>& content_view_core,
98 const jfloat dip_scale,
99 const jfloat horizontal_padding_ratio) { 92 const jfloat horizontal_padding_ratio) {
100 DCHECK(content_view_core.obj());
101 return reinterpret_cast<intptr_t>( 93 return reinterpret_cast<intptr_t>(
102 new PopupTouchHandleDrawable(env, obj, dip_scale, 94 new PopupTouchHandleDrawable(env, obj, horizontal_padding_ratio));
103 horizontal_padding_ratio));
104 } 95 }
105 96
106 } // namespace content 97 } // namespace content
OLDNEW
« no previous file with comments | « android_webview/native/popup_touch_handle_drawable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698