Issue 235863024: Make NSS work in GN build on Windows.

Issue 235863024: Make NSS work in GN build on Windows. (Closed)

Created:
6 years, 8 months ago by brettw

Modified:
6 years, 8 months ago

Reviewers:
tfarina, scottmg

CC:
chromium-reviews, tfarina, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make NSS work in GN build on Windows. This also adds sqlite which is a dependency. This required some build config changes since nss needs to opt-out of certain default settings. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264255

Total comments: 3

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1295 lines, -9 lines)			Patch
M	build/config/BUILDCONFIG.gn	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	build/config/compiler/BUILD.gn	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	build/config/gcc/BUILD.gn	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	build/config/win/BUILD.gn	View	1	2 chunks	+21 lines, -1 line	0 comments	Download
A	third_party/sqlite/BUILD.gn	View		1 chunk	+117 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/third_party/nss/BUILD.gn	View		1 chunk	+1127 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

scottmg

lgtm, but I don't pretend to understand any of the nss stuff. Assuming it's mostly ...

6 years, 8 months ago (2014-04-16 18:15:01 UTC) #2

brettw

6 years, 8 months ago (2014-04-16 18:48:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r264255 (presubmit successful).