Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2315)

Unified Diff: build/config/compiler/BUILD.gn

Issue 235863024: Make NSS work in GN build on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/gcc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index db49b4b29bf7db5db8e481b93411215dea534b68..ac00477a8a6968200830b33d6078d10fbbe8f2b9 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -43,11 +43,13 @@ config("compiler") {
# --------------------------------
cflags += [
"-fno-strict-aliasing", # See http://crbug.com/32204
- "-fvisibility=hidden",
]
cflags_cc += [
"-fno-exceptions",
"-fno-threadsafe-statics",
+ # Not exporting C++ inline functions can generally be applied anywhere
+ # so we do so here. Normal function visibility is controlled by
+ # //build/config/gcc:symbol_visibility_hidden.
"-fvisibility-inlines-hidden",
]
@@ -300,8 +302,6 @@ config("runtime_library") {
"_CRT_RAND_S",
"_CRT_SECURE_NO_DEPRECATE",
"_SCL_SECURE_NO_DEPRECATE",
- "_UNICODE",
- "UNICODE",
]
}
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/gcc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698