Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2358473002: Renamed EFloat members to match keywords (Closed)

Created:
4 years, 3 months ago by sashab
Modified:
4 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed EFloat members to match keywords Renamed EFloat members to match its keywords (none, left, right). This is pre-work to move it to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/7fbbe61b09447cc20ef89c3f1b21bde45b6c8bac Cr-Commit-Position: refs/heads/master@{#420540}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/FloatingObjects.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (13 generated)
sashab
This patch is *entirely* find and replace I'm thinking of, for future properties, just merging ...
4 years, 3 months ago (2016-09-20 06:41:59 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 3 months ago (2016-09-20 07:00:49 UTC) #3
alancutter (OOO until 2018)
On 2016/09/20 at 06:41:59, sashab wrote: > This patch is *entirely* find and replace > ...
4 years, 3 months ago (2016-09-20 07:01:14 UTC) #4
sashab
dstockwell@ for OWNERS; rs please :)
4 years, 3 months ago (2016-09-23 01:03:03 UTC) #14
dstockwell
lgtm
4 years, 3 months ago (2016-09-23 01:33:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358473002/40001
4 years, 3 months ago (2016-09-23 01:43:45 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 01:53:22 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 01:56:08 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7fbbe61b09447cc20ef89c3f1b21bde45b6c8bac
Cr-Commit-Position: refs/heads/master@{#420540}

Powered by Google App Engine
This is Rietveld 408576698