Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2351993002: Added support for non-inherited flags in ComputedStyleBase (Closed)

Created:
4 years, 3 months ago by sashab
Modified:
4 years, 2 months ago
Reviewers:
Bugs Nash, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added support for non-inherited flags in ComputedStyleBase Added support for non-inherited flags to be generated in ComputedStyleBase. Also moved Float and its enum EFloat to be generated. BUG=628043 Committed: https://crrev.com/5af0857297fe1299a2ecc4bc150c21f12f2c0750 Cr-Commit-Position: refs/heads/master@{#421754}

Patch Set 1 #

Patch Set 2 : done #

Patch Set 3 : done #

Patch Set 4 : Re-added back randomly deleted line of code that was making tests break #

Total comments: 2

Patch Set 5 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 1 chunk +16 lines, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl View 1 2 3 2 chunks +7 lines, -5 lines 1 comment Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 4 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
sashab
For reference, here is the first patch: crrev.com/2187493004 The Python script uses ComputedStyleBase.(h/cpp).tmpl to generate ...
4 years, 3 months ago (2016-09-22 06:00:42 UTC) #7
Bugs Nash
lgtm, without fully understanding how templates work
4 years, 3 months ago (2016-09-22 22:43:41 UTC) #8
sashab
Thanks bugs!! Rune@ for OWNERS review.
4 years, 3 months ago (2016-09-22 23:49:27 UTC) #10
rune
https://codereview.chromium.org/2351993002/diff/80001/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl (right): https://codereview.chromium.org/2351993002/diff/80001/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl#newcode112 third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl:112: unsigned {{field.name}} : {{field.size}}; // {{field.type}} Since we're moving ...
4 years, 3 months ago (2016-09-23 07:41:15 UTC) #15
sashab
On 2016/09/23 at 07:41:15, rune wrote: > https://codereview.chromium.org/2351993002/diff/80001/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl > File third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl (right): > > https://codereview.chromium.org/2351993002/diff/80001/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl#newcode112 ...
4 years, 2 months ago (2016-09-26 01:11:41 UTC) #16
rune
On 2016/09/26 at 01:11:41, sashab wrote: > On 2016/09/23 at 07:41:15, rune wrote: > > ...
4 years, 2 months ago (2016-09-26 07:14:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351993002/80001
4 years, 2 months ago (2016-09-29 03:43:35 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-29 05:17:28 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 05:20:45 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5af0857297fe1299a2ecc4bc150c21f12f2c0750
Cr-Commit-Position: refs/heads/master@{#421754}

Powered by Google App Engine
This is Rietveld 408576698