GN: take over CommandBuffer bot

GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/605d95289379a07aad50b38ca6badbee45813d56

[mtklein_C, 2016-09-21 18:27:17]

Description was changed from

==========
GN: take over CommandBuffer bot


BUG=skia:
==========

to

==========
GN: take over CommandBuffer bot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

[mtklein_C, 2016-09-21 19:02:44]

Description was changed from

==========
GN: take over CommandBuffer bot


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

to

==========
GN: take over CommandBuffer bot

As you suspected, I see no reason that our tools side of things can't be built
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

[mtklein_C, 2016-09-21 19:04:38]

Description was changed from

==========
GN: take over CommandBuffer bot

As you suspected, I see no reason that our tools side of things can't be built
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

to

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

[mtklein_C, 2016-09-21 19:05:07]

mtklein@chromium.org changed reviewers:
+ bsalomon@google.com

[mtklein_C, 2016-09-21 19:05:07]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:05:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 19:05:23]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-09-22 01:05 UTC

[commit-bot: I haz the power, 2016-09-21 19:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 19:08:09]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bsalomon, 2016-09-21 19:09:57]

Can we also remove the macro from the code? I don't see any reason to not build
it whenever we build the gpu tools.

[mtklein_C, 2016-09-21 19:19:26]

Description was changed from

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

to

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer-Trybot
==========

[mtklein_C, 2016-09-21 19:20:29]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:20:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-21 19:20:39]

On 2016/09/21 at 19:09:57, bsalomon wrote:
> Can we also remove the macro from the code? I don't see any reason to not
build it whenever we build the gpu tools.

Let's find out!

[bsalomon, 2016-09-21 19:39:22]

https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_bu...
File tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp (left):

https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_bu...
tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp:19: // EGL doesn't
exist on the mac, so expose what we need to get the command buffer's EGL
running.
rm comment?

[mtklein_C, 2016-09-21 19:40:21]

https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_bu...
File tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp (left):

https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_bu...
tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp:19: // EGL doesn't
exist on the mac, so expose what we need to get the command buffer's EGL
running.
On 2016/09/21 at 19:39:22, bsalomon wrote:
> rm comment?

done

[mtklein_C, 2016-09-21 19:40:50]

Description was changed from

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002

CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer-Trybot
==========

to

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

[bsalomon, 2016-09-21 19:46:42]

lgtm, but looks like we might need to unconditionally compile the command buffer
cpp file in gyp-based builds of gputest as well.

[mtklein_C, 2016-09-21 19:56:54]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-09-21 19:56:55]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2358173002/#ps120001
(title: "GYP too")

[commit-bot: I haz the power, 2016-09-21 19:56:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-21 20:50:52]

Description was changed from

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
==========

to

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
NOTREECHECKS=true
==========

[commit-bot: I haz the power, 2016-09-21 21:01:34]

Description was changed from

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
NOTREECHECKS=true
==========

to

==========
GN: take over CommandBuffer bot

As you suspected, I see nothing preventing us from building our side of things
unconditionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002
NOTREECHECKS=true

Committed:
https://skia.googlesource.com/skia/+/605d95289379a07aad50b38ca6badbee45813d56
==========

[commit-bot: I haz the power, 2016-09-21 21:01:35]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/605d95289379a07aad50b38ca6badbee45813d56