Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 2358173002: GN: take over CommandBuffer bot (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: take over CommandBuffer bot As you suspected, I see nothing preventing us from building our side of things unconditionally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/605d95289379a07aad50b38ca6badbee45813d56

Patch Set 1 #

Patch Set 2 : fix build, deconditionalize. #

Patch Set 3 : undo diff #

Patch Set 4 : --make-output-dir #

Patch Set 5 : all out #

Total comments: 2

Patch Set 6 : rm #

Patch Set 7 : GYP too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -84 lines) Patch
M BUILD.gn View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M gyp/common.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -10 lines 0 comments Download
M gyp/gputest.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M infra/bots/recipe_modules/flavor/default_flavor.py View 2 chunks +0 lines, -14 lines 0 comments Download
M infra/bots/recipe_modules/flavor/gn_flavor.py View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Mac-Clang-x86_64-Debug-CommandBuffer.json View 1 2 3 3 chunks +37 lines, -23 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-GPU-HD4000-x86_64-Debug-CommandBuffer.json View 2 chunks +1 line, -6 lines 0 comments Download
M tests/TestConfigParsing.cpp View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 1 2 3 4 3 chunks +0 lines, -6 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 1 2 3 4 2 chunks +1 line, -5 lines 0 comments Download
M tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp View 1 2 3 4 5 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
mtklein_C
4 years, 3 months ago (2016-09-21 19:05:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358173002/60001
4 years, 3 months ago (2016-09-21 19:05:22 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-21 19:05:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/1394)
4 years, 3 months ago (2016-09-21 19:08:09 UTC) #10
bsalomon
Can we also remove the macro from the code? I don't see any reason to ...
4 years, 3 months ago (2016-09-21 19:09:57 UTC) #11
mtklein_C
On 2016/09/21 at 19:09:57, bsalomon wrote: > Can we also remove the macro from the ...
4 years, 3 months ago (2016-09-21 19:20:39 UTC) #15
bsalomon
https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp File tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp (left): https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp#oldcode19 tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp:19: // EGL doesn't exist on the mac, so expose ...
4 years, 3 months ago (2016-09-21 19:39:22 UTC) #16
mtklein_C
https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp File tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp (left): https://codereview.chromium.org/2358173002/diff/80001/tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp#oldcode19 tools/gpu/gl/command_buffer/GLTestContext_command_buffer.cpp:19: // EGL doesn't exist on the mac, so expose ...
4 years, 3 months ago (2016-09-21 19:40:21 UTC) #17
bsalomon
lgtm, but looks like we might need to unconditionally compile the command buffer cpp file ...
4 years, 3 months ago (2016-09-21 19:46:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2358173002/120001
4 years, 3 months ago (2016-09-21 19:56:59 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 21:01:35 UTC) #25
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/605d95289379a07aad50b38ca6badbee45813d56

Powered by Google App Engine
This is Rietveld 408576698