Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Unified Diff: infra/bots/recipe_modules/flavor/gn_flavor.py

Issue 2358173002: GN: take over CommandBuffer bot (Closed)
Patch Set: GYP too Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipe_modules/flavor/gn_flavor.py
diff --git a/infra/bots/recipe_modules/flavor/gn_flavor.py b/infra/bots/recipe_modules/flavor/gn_flavor.py
index c91de14b09326bf7abf405a45100d4e3e862ba40..81aa1216ac5e4a849667387c4ffea3aba7b4fc4e 100644
--- a/infra/bots/recipe_modules/flavor/gn_flavor.py
+++ b/infra/bots/recipe_modules/flavor/gn_flavor.py
@@ -14,6 +14,7 @@ class GNFlavorUtils(default_flavor.DefaultFlavorUtils):
return any([
'CT' in extra_config,
'SAN' in extra_config,
+ extra_config == 'CommandBuffer',
extra_config == 'Fast',
extra_config == 'GN',
extra_config == 'Mesa',
@@ -29,6 +30,15 @@ class GNFlavorUtils(default_flavor.DefaultFlavorUtils):
self.m.run(self.m.step, title, cmd=cmd,
env=env, cwd=self.m.vars.skia_dir, infra_step=infra_step)
+ def build_command_buffer(self):
+ self.m.run(self.m.python, 'build command_buffer',
+ script=self.m.vars.skia_dir.join('tools', 'build_command_buffer.py'),
+ args=[
+ '--chrome-dir', self.m.vars.checkout_root,
+ '--output-dir', self.m.vars.skia_out.join(self.m.vars.configuration),
+ '--chrome-build-type', self.m.vars.configuration,
+ '--no-sync', '--make-output-dir'])
+
def compile(self, unused_target, **kwargs):
"""Build Skia with GN."""
compiler = self.m.vars.builder_cfg.get('compiler', '')
@@ -63,6 +73,8 @@ class GNFlavorUtils(default_flavor.DefaultFlavorUtils):
if configuration != 'Debug':
args['is_debug'] = 'false'
+ if extra_config == 'CommandBuffer':
+ self.m.run.run_once(self.build_command_buffer)
if extra_config == 'MSAN':
args['skia_use_fontconfig'] = 'false'
if extra_config == 'Mesa':

Powered by Google App Engine
This is Rietveld 408576698