Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: infra/bots/recipe_modules/flavor/default_flavor.py

Issue 2358173002: GN: take over CommandBuffer bot (Closed)
Patch Set: GYP too Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/gputest.gyp ('k') | infra/bots/recipe_modules/flavor/gn_flavor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipe_modules/flavor/default_flavor.py
diff --git a/infra/bots/recipe_modules/flavor/default_flavor.py b/infra/bots/recipe_modules/flavor/default_flavor.py
index 149403c3abf7e899fe687bdfe4edb76e21975b97..aa8669b3a491bfbea96a0969f20bef3bc7b6b859 100644
--- a/infra/bots/recipe_modules/flavor/default_flavor.py
+++ b/infra/bots/recipe_modules/flavor/default_flavor.py
@@ -117,18 +117,6 @@ class DefaultFlavorUtils(object):
'--depot_tools_parent_dir',
self._win_toolchain_dir])
- def build_command_buffer(self, **kwargs):
- """Build command_buffer."""
- script = self.m.vars.skia_dir.join('tools', 'build_command_buffer.py')
- self.m.run(
- self.m.python, 'build command_buffer',
- script=script,
- args=['--chrome-dir', self.m.vars.checkout_root,
- '--output-dir', self.out_dir,
- '--chrome-build-type', self.m.vars.configuration,
- '--no-sync'],
- **kwargs)
-
def compile(self, target, **kwargs):
"""Build the given target."""
env = kwargs.pop('env', {})
@@ -153,8 +141,6 @@ class DefaultFlavorUtils(object):
env=env, cwd=self.m.path['checkout'], **kwargs)
else:
raise
- if 'CommandBuffer' in self.m.vars.builder_name:
- self.m.run.run_once(self.build_command_buffer, env=env)
def copy_extra_build_products(self, swarming_out_dir):
"""Copy extra build products to specified directory.
« no previous file with comments | « gyp/gputest.gyp ('k') | infra/bots/recipe_modules/flavor/gn_flavor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698