Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 235783003: Fix generation of Android SampleApp APK now that we default to using gyp's ninja generator. (Closed)

Created:
6 years, 8 months ago by djsollen
Modified:
6 years, 8 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix generation of Android SampleApp APK now that we default to using gyp's ninja generator. Committed: http://code.google.com/p/skia/source/detail?r=14212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M platform_tools/android/gyp/skia_android.gypi View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
6 years, 8 months ago (2014-04-11 20:17:54 UTC) #1
scroggo
lgtm
6 years, 8 months ago (2014-04-11 21:08:35 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-15 20:29:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/235783003/1
6 years, 8 months ago (2014-04-15 20:29:54 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 21:37:14 UTC) #5
Message was sent while issue was closed.
Change committed as 14212

Powered by Google App Engine
This is Rietveld 408576698