Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: platform_tools/android/gyp/skia_android.gypi

Issue 235783003: Fix generation of Android SampleApp APK now that we default to using gyp's ninja generator. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/gyp/skia_android.gypi
diff --git a/platform_tools/android/gyp/skia_android.gypi b/platform_tools/android/gyp/skia_android.gypi
index 270b934baf94b496e8900541e40bae99d52e59c4..29813691ab357a3dcbae47f6872c506efc385911 100644
--- a/platform_tools/android/gyp/skia_android.gypi
+++ b/platform_tools/android/gyp/skia_android.gypi
@@ -58,7 +58,11 @@
'CopySampleAppDeps',
],
'variables': {
- 'ANDROID_SDK_ROOT': '<!(echo $ANDROID_SDK_ROOT)'
+ 'ANDROID_SDK_ROOT': '<!(echo $ANDROID_SDK_ROOT)',
+ # the ninja generator treats PRODUCT_DIR as a relative path to the
+ # gyp directory but android ant build wants a path relative to the
+ # build.xml file so we do that adjustment here.
+ 'ANDROID_OUT': '../../<(PRODUCT_DIR)/android'
},
'actions': [
{
@@ -81,10 +85,10 @@
'-quiet',
'-f',
'<(android_base)/app/build.xml',
- '-Dout.dir=<(PRODUCT_DIR)/android/bin',
- '-Dgen.absolute.dir=<(PRODUCT_DIR)/android/gen',
- '-Dnative.libs.absolute.dir=<(PRODUCT_DIR)/android/libs',
- '-Dout.final.file=<(PRODUCT_DIR)/android/bin/SkiaAndroid.apk',
+ '-Dout.dir=<(ANDROID_OUT)/bin',
+ '-Dgen.absolute.dir=<(ANDROID_OUT)/gen',
+ '-Dnative.libs.absolute.dir=<(ANDROID_OUT)/libs',
+ '-Dout.final.file=<(ANDROID_OUT)/bin/SkiaAndroid.apk',
'-Dsdk.dir=<(ANDROID_SDK_ROOT)',
'debug',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698